Fix Docker image build process#289
Merged
mihirsoni merged 4 commits intoopensearch-project:mainfrom Apr 15, 2021
jgough:main
Merged
Fix Docker image build process#289mihirsoni merged 4 commits intoopensearch-project:mainfrom jgough:main
mihirsoni merged 4 commits intoopensearch-project:mainfrom
jgough:main
Conversation
The Dockerfile was still building kibana so updated to build OpenSearch-Dashboards. Some fields in the Docker image labels may need updating but setting to some fairly sensible values for now. Additionally some future work to be done around public artefacts that AFAIK don't exist yet. Signed-off-by: Jonathan Gough <jonathanpgough@gmail.com>
This needs eventually updating to a correct URI but for now this should suffice Signed-off-by: Jonathan Gough <jonathanpgough@gmail.com>
Signed-off-by: Jonathan Gough <jonathanpgough@gmail.com>
|
✅ DCO Check Passed f846f33 |
kavilla
previously approved these changes
Apr 14, 2021
Member
kavilla
left a comment
There was a problem hiding this comment.
LGTM! Pulled it down and was able to build docker containers. Thank you!
| RUN cd /opt && \ | ||
| curl --retry 8 -s -L -O https://artifacts.opensearch.co/downloads/kibana/{{artifactTarball}} && \ | ||
| cd - | ||
| # TODO: Update this link or remove functionality |
Member
There was a problem hiding this comment.
Don't need to do for this PR but for these I end up appended [RENAMEME] to the TODO's so that we can track it a little bit easier. So we will end up updating all these artifact links with real links.
mihirsoni
reviewed
Apr 14, 2021
mihirsoni
reviewed
Apr 14, 2021
|
❌ DCO Check Failed 68d71e4 |
Signed-off-by: Jonathan Gough <jonathanpgough@gmail.com>
|
✅ DCO Check Passed 26b2b17 |
kavilla
pushed a commit
that referenced
this pull request
May 21, 2021
* Fix Dockerfile to build OpenSearch-Dashboards The Dockerfile was still building kibana so updated to build OpenSearch-Dashboards. Some fields in the Docker image labels may need updating but setting to some fairly sensible values for now. Additionally some future work to be done around public artefacts that AFAIK don't exist yet. Signed-off-by: Jonathan Gough <jonathanpgough@gmail.com> * Change docker image host to opensearch.org This needs eventually updating to a correct URI but for now this should suffice Signed-off-by: Jonathan Gough <jonathanpgough@gmail.com> * Removing x-pack code Signed-off-by: Jonathan Gough <jonathanpgough@gmail.com> * Update name to OpenSearch Dashboards Signed-off-by: Jonathan Gough <jonathanpgough@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes the Docker image building process that was still trying to build kibana
Issues Resolved
#285
Check List