[Rename] Renames elastic-safer-lodash-set dependency#252
[Rename] Renames elastic-safer-lodash-set dependency#252boktorbb merged 1 commit intoopensearch-project:mainfrom boktorbb:rename-lodash
Conversation
|
✅ DCO Check Passed 17ab2b6 |
Renames the elastic-safer-lodash-set to opensearch-safer-lodash-set and updated precommit hook rules and eslintignore since this package file names need to match upstream lodash Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
|
✅ DCO Check Passed bf269d7 |
mihirsoni
left a comment
There was a problem hiding this comment.
LGTM !! Still concerned on why this files are deleted / added :(
|
Still references to the old package name in the README, did we want to update those? Also did we want to update the package.json values? I am unable to build this PR. Should I be pulling down all the PRs for building? |
kavilla
left a comment
There was a problem hiding this comment.
Also, in .eslintrc.js we tell people to use this package instead of the original lodash in when they try to use lodash.set, lodash.setWith. Did we want to update that as well with this PR?
Yes, can you pull all 3 PRs down |
I was directed to only rename the top level dir and nothing else |
|
we are told to keep things mostly the same, so after cherry-picking all the commits, everything resolved so my comments can be resolved. |
Renames the elastic-safer-lodash-set to opensearch-safer-lodash-set and updated precommit hook rules and eslintignore since this package file names need to match upstream lodash Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
…opensearch-project#253) (cherry picked from commit 734c890) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…n management and SavedObject management as standalone app, retire dashboard management (opensearch-project#283) * Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (opensearch-project#208)" This reverts commit 5f09f84. * Revert "feat: add unit test for mountWrapper (opensearch-project#223)" This reverts commit a70ce71. * Revert "fix: cypress tests checkout workspace branch (opensearch-project#252)" This reverts commit 734c890. * run cypress with ftr main Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
…n management and SavedObject management as standalone app, retire dashboard management (opensearch-project#283) * Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (opensearch-project#208)" This reverts commit 5f09f84. * Revert "feat: add unit test for mountWrapper (opensearch-project#223)" This reverts commit a70ce71. * Revert "fix: cypress tests checkout workspace branch (opensearch-project#252)" This reverts commit 734c890. * run cypress with ftr main Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Description
Renames elastic-safer-lodash-set --> opensearch-safer-lodash-set
Check List