Skip to content

Enforce up-to-date Guava in buildSrc#9335

Merged
reta merged 1 commit intoopensearch-project:mainfrom
Xtansia:fix/force-guava-in-build-tools
Aug 15, 2023
Merged

Enforce up-to-date Guava in buildSrc#9335
reta merged 1 commit intoopensearch-project:mainfrom
Xtansia:fix/force-guava-in-build-tools

Conversation

@Xtansia
Copy link
Copy Markdown
Contributor

@Xtansia Xtansia commented Aug 15, 2023

Description

Enforces up-to-date Guava in buildSrc.
Guava is a transitive dependency of spotless via google-java-format, the version that was being pulled in has CVE-2023-2976. While this would not affect end users it causes excess alerts.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Guava is a transitive dependency of spotless via google-java-format, the version that was being pulled in has CVE-2023-2976.
While this would not affect end users it causes excess alerts.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 15, 2023

Codecov Report

Merging #9335 (710367e) into main (9dca96d) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #9335      +/-   ##
============================================
+ Coverage     71.15%   71.20%   +0.04%     
- Complexity    57452    57505      +53     
============================================
  Files          4777     4777              
  Lines        270705   270705              
  Branches      39565    39565              
============================================
+ Hits         192629   192759     +130     
+ Misses        61909    61761     -148     
- Partials      16167    16185      +18     

see 474 files with indirect coverage changes

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 30m 23s

@reta reta merged commit 1342578 into opensearch-project:main Aug 15, 2023
@reta reta added the backport 2.x Backport to 2.x branch label Aug 15, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 15, 2023
Guava is a transitive dependency of spotless via google-java-format, the version that was being pulled in has CVE-2023-2976.
While this would not affect end users it causes excess alerts.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 1342578)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Aug 15, 2023
Guava is a transitive dependency of spotless via google-java-format, the version that was being pulled in has CVE-2023-2976.
While this would not affect end users it causes excess alerts.


(cherry picked from commit 1342578)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Xtansia Xtansia deleted the fix/force-guava-in-build-tools branch August 15, 2023 20:29
kkmr pushed a commit to kkmr/OpenSearch that referenced this pull request Aug 28, 2023
Guava is a transitive dependency of spotless via google-java-format, the version that was being pulled in has CVE-2023-2976.
While this would not affect end users it causes excess alerts.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Kiran Reddy <kkreddy@amazon.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
Guava is a transitive dependency of spotless via google-java-format, the version that was being pulled in has CVE-2023-2976.
While this would not affect end users it causes excess alerts.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
kotwanikunal pushed a commit to kotwanikunal/OpenSearch that referenced this pull request Sep 13, 2023
Guava is a transitive dependency of spotless via google-java-format, the version that was being pulled in has CVE-2023-2976.
While this would not affect end users it causes excess alerts.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 1342578)
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
Guava is a transitive dependency of spotless via google-java-format, the version that was being pulled in has CVE-2023-2976.
While this would not affect end users it causes excess alerts.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Guava is a transitive dependency of spotless via google-java-format, the version that was being pulled in has CVE-2023-2976.
While this would not affect end users it causes excess alerts.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants