Fix null_pointer_exception when creating or updating ingest pipeline by gaobinlong · Pull Request #9259 · opensearch-project/OpenSearch

gaobinlong · 2023-08-11T11:25:43Z

Description

Fix the bug of throwing null_pointer_exception when creating or updating ingest pipeline, add null check for the config of processor, if the config is null, return 400 http status code.

Related Issues

#9257

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

opensearch-trigger-bot · 2023-08-11T11:47:34Z

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 21m 26s

opensearch-trigger-bot · 2023-08-11T11:53:49Z

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/reporting.git]
Compatible components: [https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 26m 26s

github-actions · 2023-08-11T12:07:52Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/22453/
CommitID: 6e215b3

codecov · 2023-08-11T12:09:44Z

Codecov Report

Merging #9259 (0a92736) into main (731e043) will decrease coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #9259      +/-   ##
============================================
- Coverage     71.25%   71.19%   -0.07%     
- Complexity    57811    57824      +13     
============================================
  Files          4806     4806              
  Lines        272240   272244       +4     
  Branches      39730    39731       +1     
============================================
- Hits         193996   193824     -172     
- Misses        61941    62167     +226     
+ Partials      16303    16253      -50

Files Changed	Coverage Δ
...java/org/opensearch/ingest/ConfigurationUtils.java	`76.87% <100.00%> (+0.54%)`	⬆️

... and 481 files with indirect coverage changes

github-actions · 2023-08-11T12:15:23Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testRemoteTranslogCleanup
      1 org.opensearch.remotestore.RemoteStoreIT.testRemoteTranslogCleanup

URL: https://build.ci.opensearch.org/job/gradle-check/22454/
CommitID: 15d92b5
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

server/src/main/java/org/opensearch/ingest/ConfigurationUtils.java

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

opensearch-trigger-bot · 2023-08-14T03:36:05Z

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 35m 13s

opensearch-trigger-bot · 2023-08-14T03:36:50Z

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 35m 35s

github-actions · 2023-08-14T03:39:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/22595/
CommitID: 2cea65b
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-08-14T03:58:50Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/22596/
CommitID: 3de7e8f
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

opensearch-trigger-bot · 2023-08-14T04:52:16Z

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

BUILD SUCCESSFUL in 26m 25s

github-actions · 2023-08-14T05:08:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.index.ShardIndexingPressureIT.testShardIndexingPressureTrackingDuringBulkWrites

URL: https://build.ci.opensearch.org/job/gradle-check/22602/
CommitID: 4aaf9a8
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

server/src/main/java/org/opensearch/ingest/ConfigurationUtils.java

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

opensearch-trigger-bot · 2023-08-14T15:00:09Z

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 33m 32s

github-actions · 2023-08-14T15:10:33Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/22648/
CommitID: 5b57071
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-08-14T16:17:37Z

Gradle Check (Jenkins) Run Completed with:

RESULT: ❌
URL: https://build.ci.opensearch.org/job/gradle-check/22654/
CommitID: 5b57071
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

github-actions · 2023-09-04T09:41:19Z

Compatibility status:

Checks if related components are compatible with change 0a92736

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

github-actions · 2023-09-04T09:54:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/24320/
CommitID: 0a92736

gaobinlong · 2023-09-04T10:28:47Z

hi @reta, could this PR be merged now?

…9259) * Fix null_pointer_exception when creating or update ingest pipeline Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify changelog Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add nullable tag Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add more test Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify error message Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> (cherry picked from commit 4294d44) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…9259) (#9733) * Fix null_pointer_exception when creating or update ingest pipeline * Modify changelog * Add nullable tag * Add more test * Modify error message --------- (cherry picked from commit 4294d44) Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…pensearch-project#9259) * Fix null_pointer_exception when creating or update ingest pipeline Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify changelog Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add nullable tag Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add more test Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify error message Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

…pensearch-project#9259) * Fix null_pointer_exception when creating or update ingest pipeline Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify changelog Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add nullable tag Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add more test Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify error message Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>

…pensearch-project#9259) * Fix null_pointer_exception when creating or update ingest pipeline Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify changelog Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add nullable tag Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add more test Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify error message Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

Fix null_pointer_exception when creating or update ingest pipeline

6e215b3

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

Modify changelog

15d92b5

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

reta reviewed Aug 11, 2023

View reviewed changes

server/src/main/java/org/opensearch/ingest/ConfigurationUtils.java Show resolved Hide resolved

gaobinlong added 2 commits August 14, 2023 10:59

Add nullable tag

2cea65b

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

Merge remote-tracking branch 'upstream/main' into fix_ingest_bug

3de7e8f

Add more test

4aaf9a8

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

reta reviewed Aug 14, 2023

View reviewed changes

server/src/main/java/org/opensearch/ingest/ConfigurationUtils.java Outdated Show resolved Hide resolved

Modify error message

5b57071

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

reta approved these changes Aug 14, 2023

View reviewed changes

merge main

0a92736

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

gaobinlong requested a review from msfroh as a code owner September 4, 2023 09:11

reta merged commit 4294d44 into opensearch-project:main Sep 4, 2023

reta added the backport 2.x Backport to 2.x branch label Sep 4, 2023

opensearch-trigger-bot bot mentioned this pull request Sep 4, 2023

[Backport 2.x] Fix null_pointer_exception when creating or updating ingest pipeline #9733

Merged

reta mentioned this pull request Jul 17, 2024

Add Gao Binlong as maintainer #14796

Merged

3 tasks

Conversation

gaobinlong commented Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

opensearch-trigger-bot bot commented Aug 11, 2023

Uh oh!

opensearch-trigger-bot bot commented Aug 11, 2023

Uh oh!

github-actions bot commented Aug 11, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov bot commented Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Aug 11, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

opensearch-trigger-bot bot commented Aug 14, 2023

Uh oh!

opensearch-trigger-bot bot commented Aug 14, 2023

Uh oh!

github-actions bot commented Aug 14, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 14, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

opensearch-trigger-bot bot commented Aug 14, 2023

Uh oh!

github-actions bot commented Aug 14, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

opensearch-trigger-bot bot commented Aug 14, 2023

Uh oh!

github-actions bot commented Aug 14, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Aug 14, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Sep 4, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

Uh oh!

github-actions bot commented Sep 4, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

gaobinlong commented Sep 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gaobinlong commented Aug 11, 2023 •

edited

Loading

codecov bot commented Aug 11, 2023 •

edited

Loading