Add @sachinpkale as an OpenSearch maintainer by andrross · Pull Request #8019 · opensearch-project/OpenSearch

andrross · 2023-06-12T17:44:22Z

I have nominated and maintainers have agreed to invite Sachin Kale (@sachinpkale) to be a co-maintainer. Sachin has kindly accepted.

Sachin has led the design and implementation of the remote backed storage feature in OpenSearch. This feature was introduced as experimental in OpenSearch 2.3 and is planned for general availability in 2.9. Some significant issues and PRs authored by Sachin for this effort are as follows:

Feature proposal: #1968
Upload segments to remote store post refresh: #3460
Add rest endpoint for remote store restore: #3576
Add RemoteSegmentStoreDirectory to interact with remote segment store: #4020

In total, Sachin has authored 57 PRs going back to May 2022. He also frequently reviews contributions from others and has reviewed nearly 100 PRs in the same time frame.

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-06-12T18:17:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure

URL: https://build.ci.opensearch.org/job/gradle-check/17334/
CommitID: 3a43576
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-06-12T18:23:24Z

Codecov Report

Merging #8019 (9143090) into main (5c32256) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8019      +/-   ##
============================================
- Coverage     70.88%   70.85%   -0.04%     
- Complexity    56561    56572      +11     
============================================
  Files          4719     4719              
  Lines        267446   267446              
  Branches      39210    39210              
============================================
- Hits         189582   189498      -84     
- Misses        61873    61926      +53     
- Partials      15991    16022      +31

see 462 files with indirect coverage changes

reta · 2023-06-12T18:53:32Z

CODEOWNERS will be changed separately?

@sachinpkale

I have nominated and maintainers have agreed to invite Sachin Kale (@sachinpkale) to be a co-maintainer. Sachin has kindly accepted. Sachin has led the design and implementation of the remote backed storage feature in OpenSearch. This feature was introduced as experimental in OpenSearch 2.3 and is planned for general availability in 2.9. Some significant issues and PRs authored by Sachin for this effort are as follows: Feature proposal: opensearch-project#1968 Upload segments to remote store post refresh: opensearch-project#3460 Add rest endpoint for remote store restore: opensearch-project#3576 Add RemoteSegmentStoreDirectory to interact with remote segment store: opensearch-project#4020 In total, Sachin has authored 57 PRs going back to May 2022. He also frequently reviews contributions from others and has reviewed nearly 100 PRs in the same time frame. Signed-off-by: Andrew Ross <andrross@amazon.com>

github-actions · 2023-06-12T19:10:08Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/17342/
CommitID: 84678a7
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

andrross · 2023-06-12T19:19:12Z

CODEOWNERS will be changed separately?

I missed that! Updated the PR.

github-actions · 2023-06-12T19:43:10Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchTaskCancellationWithHighCpu
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testCancelPrimaryAllocation

URL: https://build.ci.opensearch.org/job/gradle-check/17343/
CommitID: 9143090
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

gaiksaya · 2023-06-12T21:39:21Z

Permissions are updated now:

opensearch-trigger-bot · 2023-06-13T19:41:15Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8019-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c45073c2e8c8eb850f707fae2adf3ca37c08c896
# Push it to GitHub
git push --set-upstream origin backport/backport-8019-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8019-to-2.x.

@sachinpkale

I have nominated and maintainers have agreed to invite Sachin Kale (@sachinpkale) to be a co-maintainer. Sachin has kindly accepted. Sachin has led the design and implementation of the remote backed storage feature in OpenSearch. This feature was introduced as experimental in OpenSearch 2.3 and is planned for general availability in 2.9. Some significant issues and PRs authored by Sachin for this effort are as follows: Feature proposal: opensearch-project#1968 Upload segments to remote store post refresh: opensearch-project#3460 Add rest endpoint for remote store restore: opensearch-project#3576 Add RemoteSegmentStoreDirectory to interact with remote segment store: opensearch-project#4020 In total, Sachin has authored 57 PRs going back to May 2022. He also frequently reviews contributions from others and has reviewed nearly 100 PRs in the same time frame. Signed-off-by: Andrew Ross <andrross@amazon.com>

@sachinpkale

I have nominated and maintainers have agreed to invite Sachin Kale (@sachinpkale) to be a co-maintainer. Sachin has kindly accepted. Sachin has led the design and implementation of the remote backed storage feature in OpenSearch. This feature was introduced as experimental in OpenSearch 2.3 and is planned for general availability in 2.9. Some significant issues and PRs authored by Sachin for this effort are as follows: Feature proposal: #1968 Upload segments to remote store post refresh: #3460 Add rest endpoint for remote store restore: #3576 Add RemoteSegmentStoreDirectory to interact with remote segment store: #4020 In total, Sachin has authored 57 PRs going back to May 2022. He also frequently reviews contributions from others and has reviewed nearly 100 PRs in the same time frame. Signed-off-by: Andrew Ross <andrross@amazon.com>

@sachinpkale

opensearch-project#8047) I have nominated and maintainers have agreed to invite Sachin Kale (@sachinpkale) to be a co-maintainer. Sachin has kindly accepted. Sachin has led the design and implementation of the remote backed storage feature in OpenSearch. This feature was introduced as experimental in OpenSearch 2.3 and is planned for general availability in 2.9. Some significant issues and PRs authored by Sachin for this effort are as follows: Feature proposal: opensearch-project#1968 Upload segments to remote store post refresh: opensearch-project#3460 Add rest endpoint for remote store restore: opensearch-project#3576 Add RemoteSegmentStoreDirectory to interact with remote segment store: opensearch-project#4020 In total, Sachin has authored 57 PRs going back to May 2022. He also frequently reviews contributions from others and has reviewed nearly 100 PRs in the same time frame. Signed-off-by: Andrew Ross <andrross@amazon.com>

@sachinpkale

I have nominated and maintainers have agreed to invite Sachin Kale (@sachinpkale) to be a co-maintainer. Sachin has kindly accepted. Sachin has led the design and implementation of the remote backed storage feature in OpenSearch. This feature was introduced as experimental in OpenSearch 2.3 and is planned for general availability in 2.9. Some significant issues and PRs authored by Sachin for this effort are as follows: Feature proposal: opensearch-project#1968 Upload segments to remote store post refresh: opensearch-project#3460 Add rest endpoint for remote store restore: opensearch-project#3576 Add RemoteSegmentStoreDirectory to interact with remote segment store: opensearch-project#4020 In total, Sachin has authored 57 PRs going back to May 2022. He also frequently reviews contributions from others and has reviewed nearly 100 PRs in the same time frame. Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

@sachinpkale

I have nominated and maintainers have agreed to invite Sachin Kale (@sachinpkale) to be a co-maintainer. Sachin has kindly accepted. Sachin has led the design and implementation of the remote backed storage feature in OpenSearch. This feature was introduced as experimental in OpenSearch 2.3 and is planned for general availability in 2.9. Some significant issues and PRs authored by Sachin for this effort are as follows: Feature proposal: opensearch-project#1968 Upload segments to remote store post refresh: opensearch-project#3460 Add rest endpoint for remote store restore: opensearch-project#3576 Add RemoteSegmentStoreDirectory to interact with remote segment store: opensearch-project#4020 In total, Sachin has authored 57 PRs going back to May 2022. He also frequently reviews contributions from others and has reviewed nearly 100 PRs in the same time frame. Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

andrross added the skip-changelog label Jun 12, 2023

andrross requested review from Bukhtawar, CEHENKLE, Rishikesh1159, VachaShah, anasalkouz, dblock, dbwiddis, dreamer-89, gbbafna, kartg, kotwanikunal, mch2, nknize, owaiskazi19, reta, ryanbogan, saratvemulapalli, setiah, shwetathareja and tlfeng as code owners June 12, 2023 17:44

kotwanikunal approved these changes Jun 12, 2023

View reviewed changes

andrross added the backport 2.x Backport to 2.x branch label Jun 12, 2023

Bukhtawar approved these changes Jun 12, 2023

View reviewed changes

kartg approved these changes Jun 12, 2023

View reviewed changes

reta approved these changes Jun 12, 2023

View reviewed changes

andrross force-pushed the sachin-maintainer branch from 3a43576 to 84678a7 Compare June 12, 2023 19:04

andrross force-pushed the sachin-maintainer branch from 84678a7 to 9143090 Compare June 12, 2023 19:05

kotwanikunal merged commit c45073c into opensearch-project:main Jun 12, 2023

andrross deleted the sachin-maintainer branch June 12, 2023 23:14

andrross added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Jun 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add @sachinpkale as an OpenSearch maintainer#8019

Add @sachinpkale as an OpenSearch maintainer#8019
kotwanikunal merged 1 commit intoopensearch-project:mainfrom
andrross:sachin-maintainer

andrross commented Jun 12, 2023

Uh oh!

github-actions bot commented Jun 12, 2023

Uh oh!

codecov bot commented Jun 12, 2023 •

edited

Loading

Uh oh!

reta commented Jun 12, 2023

Uh oh!

github-actions bot commented Jun 12, 2023

Uh oh!

andrross commented Jun 12, 2023

Uh oh!

github-actions bot commented Jun 12, 2023

Uh oh!

gaiksaya commented Jun 12, 2023

Uh oh!

opensearch-trigger-bot bot commented Jun 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

andrross commented Jun 12, 2023

Check List

Uh oh!

github-actions bot commented Jun 12, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov bot commented Jun 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

reta commented Jun 12, 2023

Uh oh!

github-actions bot commented Jun 12, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

andrross commented Jun 12, 2023

Uh oh!

github-actions bot commented Jun 12, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

gaiksaya commented Jun 12, 2023

Uh oh!

opensearch-trigger-bot bot commented Jun 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Jun 12, 2023 •

edited

Loading