Generic Streamable Registry#7780
Merged
nknize merged 4 commits intoopensearch-project:mainfrom May 30, 2023
Merged
Conversation
This commit adds a WriteableRegistry to register generic read / write serialization methods for StreamInput.readGeneric and StreamOutput.writeGeneric. This enables modules, plugins, and libraries to register their own type serialization logic without forcing the class implementation to be in the :server module. Decoupling this logic also further decouples the StreamInput / StreamOutput transport logic from the server module such that it can be refactored to the core library to support cloud native and serverless implementations. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7780 +/- ##
============================================
+ Coverage 70.72% 70.85% +0.12%
- Complexity 56146 56179 +33
============================================
Files 4682 4683 +1
Lines 266102 266113 +11
Branches 39070 39075 +5
============================================
+ Hits 188193 188545 +352
+ Misses 61935 61609 -326
+ Partials 15974 15959 -15
|
reta
reviewed
May 26, 2023
libs/core/src/main/java/org/opensearch/core/common/io/stream/BaseWriteable.java
Outdated
Show resolved
Hide resolved
reta
reviewed
May 26, 2023
libs/core/src/main/java/org/opensearch/core/common/io/stream/BaseWriteable.java
Show resolved
Hide resolved
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
1 similar comment
Contributor
Gradle Check (Jenkins) Run Completed with:
|
reta
reviewed
May 29, 2023
libs/core/src/main/java/org/opensearch/core/common/io/stream/BaseWriteable.java
Outdated
Show resolved
Hide resolved
reta
reviewed
May 29, 2023
libs/core/src/main/java/org/opensearch/core/common/io/stream/BaseWriteable.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
reta
reviewed
May 30, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
reta
approved these changes
May 30, 2023
2 tasks
This was referenced May 31, 2023
stephen-crawford
pushed a commit
to stephen-crawford/OpenSearch
that referenced
this pull request
May 31, 2023
This commit adds a WriteableRegistry to register generic read / write serialization methods for StreamInput.readGeneric and StreamOutput.writeGeneric. This enables modules, plugins, and libraries to register their own type serialization logic without forcing the class implementation to be in the :server module. Decoupling this logic also further decouples the StreamInput / StreamOutput transport logic from the server module such that it can be refactored to the core library to support cloud native and serverless implementations. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Jun 2, 2023
This commit adds a WriteableRegistry to register generic read / write serialization methods for StreamInput.readGeneric and StreamOutput.writeGeneric. This enables modules, plugins, and libraries to register their own type serialization logic without forcing the class implementation to be in the :server module. Decoupling this logic also further decouples the StreamInput / StreamOutput transport logic from the server module such that it can be refactored to the core library to support cloud native and serverless implementations. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
3 tasks
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
This commit adds a WriteableRegistry to register generic read / write serialization methods for StreamInput.readGeneric and StreamOutput.writeGeneric. This enables modules, plugins, and libraries to register their own type serialization logic without forcing the class implementation to be in the :server module. Decoupling this logic also further decouples the StreamInput / StreamOutput transport logic from the server module such that it can be refactored to the core library to support cloud native and serverless implementations. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a WriteableRegistry to register generic read / write serialization methods for StreamInput.readGeneric and StreamOutput.writeGeneric. This enables modules, plugins, and libraries to register their own type serialization logic without forcing the class implementation to be in the :server module.
Decoupling this logic also further decouples the StreamInput / StreamOutput transport logic from the server module such that it can be refactored to the core library to support cloud native and serverless implementations.
relates #5910