Resolve windows opensearch-env.bat having variable delayed expansion issues on OPENSEARCH_HOME assignment introduced in #6956 by peterzhuamazon · Pull Request #7080 · opensearch-project/OpenSearch

peterzhuamazon · 2023-04-10T22:38:44Z

Description

Resolve windows opensearch-env.bat having variable delayed expansion issues on OPENSEARCH_HOME assignment introduced in #6956

Issues Resolved

#6956 (comment)
opensearch-project/security#2657

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-04-10T22:42:31Z

Gradle Check (Jenkins) Run Completed with:

RESULT: ABORTED ❌
URL: https://build.ci.opensearch.org/job/gradle-check/13804/
CommitID: 7e9f915
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

…issues on OPENSEARCH_HOME assignment Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

peterzhuamazon · 2023-04-11T17:05:36Z

Hi @andrross I have resolved the changelog comment you mentioned.
Please review again.
Thanks!

…ome-error

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

github-actions · 2023-04-11T17:32:08Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/13862/
CommitID: 178a00a
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-04-11T17:33:59Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/13860/
CommitID: 1a1d678

github-actions · 2023-04-11T17:38:44Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/13861/
CommitID: 849e521

github-actions · 2023-04-11T18:20:41Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/13869/
CommitID: 178a00a

DarshitChanpura

This will hopefully solve Windows CI woes across plugins. Ty @peterzhuamazon !!

opensearch-trigger-bot · 2023-04-11T19:13:09Z

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-7080-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 810b98555ea612cbae8310bf670cd515eb8cab34
# Push it to GitHub
git push --set-upstream origin backport/backport-7080-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-7080-to-1.x.

opensearch-trigger-bot · 2023-04-11T19:13:10Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7080-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 810b98555ea612cbae8310bf670cd515eb8cab34
# Push it to GitHub
git push --set-upstream origin backport/backport-7080-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7080-to-2.x.

peterzhuamazon · 2023-04-11T19:37:47Z

Will create backports of this soon.

peterzhuamazon · 2023-04-11T19:40:22Z

It merged now.
Rebuilding the 3.0.0 artifacts which would take some time.
Thanks.

…issues on OPENSEARCH_HOME assignment introduced in #6956 (#7080) * Resolve windows opensearch-env.bat having variable delayed expansion issues on OPENSEARCH_HOME assignment Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove changelog entry Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 810b985) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…issues on OPENSEARCH_HOME assignment introduced in #6956 (#7080) (#7109) * Resolve windows opensearch-env.bat having variable delayed expansion issues on OPENSEARCH_HOME assignment * Remove changelog entry --------- (cherry picked from commit 810b985) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…issues on OPENSEARCH_HOME assignment introduced in #6956 (#7080) * Resolve windows opensearch-env.bat having variable delayed expansion issues on OPENSEARCH_HOME assignment Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove changelog entry Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 810b985) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…issues on OPENSEARCH_HOME assignment introduced in #6956 (#7080) (#7111) * Resolve windows opensearch-env.bat having variable delayed expansion issues on OPENSEARCH_HOME assignment * Remove changelog entry --------- (cherry picked from commit 810b985) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…issues on OPENSEARCH_HOME assignment introduced in opensearch-project#6956 (opensearch-project#7080) * Resolve windows opensearch-env.bat having variable delayed expansion issues on OPENSEARCH_HOME assignment Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove changelog entry Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

peterzhuamazon added bug Something isn't working windows backport 1.x backport 2.x Backport to 2.x branch labels Apr 10, 2023

peterzhuamazon self-assigned this Apr 10, 2023

peterzhuamazon requested review from Bukhtawar, CEHENKLE, Rishikesh1159, VachaShah, anasalkouz, andrross, dblock, dreamer-89, gbbafna, kartg, kotwanikunal, mch2, nknize, owaiskazi19, reta, ryanbogan, saratvemulapalli, setiah, shwetathareja, tlfeng and xuezhou25 as code owners April 10, 2023 22:38

peterzhuamazon changed the title ~~Resolve windows opensearch-env.bat having variable delayed expansion issues on OPENSEARCH_HOME assignment~~ Resolve windows opensearch-env.bat having variable delayed expansion issues on OPENSEARCH_HOME assignment introduced in #6956 Apr 10, 2023

This was referenced Apr 10, 2023

feat: allow overwrite opensearch home #6956

Merged

feat: allow overwrite opensearch home to 1.x #7050

Merged

Resolve windows opensearch-env.bat having variable delayed expansion …

1a1d678

…issues on OPENSEARCH_HOME assignment Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

peterzhuamazon force-pushed the resolve-windows-oshome-error branch from 560be68 to 1a1d678 Compare April 11, 2023 17:05

peterzhuamazon added 2 commits April 11, 2023 13:06

Merge remote-tracking branch 'upstream/main' into resolve-windows-osh…

849e521

…ome-error

Remove changelog entry

178a00a

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

peterzhuamazon mentioned this pull request Apr 11, 2023

Add generatePomFileForPluginZipPublication as dependency of publishNebulaPublicationToSnapshotsRepository opensearch-project/job-scheduler#360

Merged

5 tasks

msfroh mentioned this pull request Apr 11, 2023

adding Sean Li - sejli as a maintainer opensearch-project/search-processor#128

Merged

5 tasks

andrross approved these changes Apr 11, 2023

View reviewed changes

DarshitChanpura approved these changes Apr 11, 2023

View reviewed changes

peterzhuamazon merged commit 810b985 into opensearch-project:main Apr 11, 2023

peterzhuamazon deleted the resolve-windows-oshome-error branch April 11, 2023 19:12

peterzhuamazon added backport 1.x and removed backport 1.x labels Apr 11, 2023

opensearch-trigger-bot bot mentioned this pull request Apr 11, 2023

[Backport 1.x] Resolve windows opensearch-env.bat having variable delayed expansion issues on OPENSEARCH_HOME assignment introduced in #6956 #7109

Merged

peterzhuamazon added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Apr 11, 2023

opensearch-trigger-bot bot mentioned this pull request Apr 11, 2023

[Backport 2.x] Resolve windows opensearch-env.bat having variable delayed expansion issues on OPENSEARCH_HOME assignment introduced in #6956 #7111

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolve windows opensearch-env.bat having variable delayed expansion issues on OPENSEARCH_HOME assignment introduced in #6956#7080

Resolve windows opensearch-env.bat having variable delayed expansion issues on OPENSEARCH_HOME assignment introduced in #6956#7080
peterzhuamazon merged 3 commits intoopensearch-project:mainfrom
peterzhuamazon:resolve-windows-oshome-error

peterzhuamazon commented Apr 10, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Apr 10, 2023

Uh oh!

peterzhuamazon commented Apr 11, 2023

Uh oh!

github-actions bot commented Apr 11, 2023

Uh oh!

github-actions bot commented Apr 11, 2023

Uh oh!

github-actions bot commented Apr 11, 2023

Uh oh!

github-actions bot commented Apr 11, 2023

Uh oh!

DarshitChanpura left a comment

Uh oh!

opensearch-trigger-bot bot commented Apr 11, 2023

Uh oh!

opensearch-trigger-bot bot commented Apr 11, 2023

Uh oh!

peterzhuamazon commented Apr 11, 2023

Uh oh!

peterzhuamazon commented Apr 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

peterzhuamazon commented Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Check List

Uh oh!

github-actions bot commented Apr 10, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

peterzhuamazon commented Apr 11, 2023

Uh oh!

github-actions bot commented Apr 11, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Apr 11, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Apr 11, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Apr 11, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

DarshitChanpura left a comment

Choose a reason for hiding this comment

Uh oh!

opensearch-trigger-bot bot commented Apr 11, 2023

Uh oh!

opensearch-trigger-bot bot commented Apr 11, 2023

Uh oh!

peterzhuamazon commented Apr 11, 2023

Uh oh!

peterzhuamazon commented Apr 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

peterzhuamazon commented Apr 10, 2023 •

edited

Loading