Skip to content

[Backport 2.x] [Refactor] Requests to use MediaType instead of XContentType (#6218)#6433

Merged
nknize merged 1 commit intoopensearch-project:2.xfrom
nknize:backport/backport-6218-to-2.x
Feb 22, 2023
Merged

[Backport 2.x] [Refactor] Requests to use MediaType instead of XContentType (#6218)#6433
nknize merged 1 commit intoopensearch-project:2.xfrom
nknize:backport/backport-6218-to-2.x

Conversation

@nknize
Copy link
Copy Markdown
Contributor

@nknize nknize commented Feb 22, 2023

Backport 1f4cdd2 from #6218.

…rch-project#6218)

Refactors various REST requests to use MediaType instead of XContentType to
abstract media format from the REST interfaces.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 22, 2023

Codecov Report

❌ Patch coverage is 50.94340% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.37%. Comparing base (47a3aba) to head (ad09bbe).
⚠️ Report is 2423 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../opensearch/client/indices/CreateIndexRequest.java 7.69% 12 Missing ⚠️
...ction/admin/indices/create/CreateIndexRequest.java 0.00% 12 Missing ⚠️
...g/opensearch/client/indices/PutMappingRequest.java 25.00% 9 Missing ⚠️
...g/opensearch/action/ingest/PutPipelineRequest.java 0.00% 7 Missing ⚠️
...org/opensearch/common/xcontent/XContentHelper.java 66.66% 4 Missing and 3 partials ⚠️
...search/client/indices/PutIndexTemplateRequest.java 42.85% 4 Missing ⚠️
...ch/common/xcontent/json/JsonXContentGenerator.java 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #6433      +/-   ##
============================================
- Coverage     70.40%   70.37%   -0.04%     
- Complexity    59222    59253      +31     
============================================
  Files          4798     4798              
  Lines        284215   284302      +87     
  Branches      41317    41321       +4     
============================================
- Hits         200100   200068      -32     
- Misses        67417    67446      +29     
- Partials      16698    16788      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Rishikesh1159 added a commit to Rishikesh1159/OpenSearch that referenced this pull request Mar 19, 2023
Rishikesh1159 added a commit to Rishikesh1159/OpenSearch that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants