Fix a bug on handling an invalid array value for point type field#4900
Merged
dblock merged 1 commit intoopensearch-project:mainfrom Oct 25, 2022
Merged
Fix a bug on handling an invalid array value for point type field#4900dblock merged 1 commit intoopensearch-project:mainfrom
dblock merged 1 commit intoopensearch-project:mainfrom
Conversation
With this commit, appropriate exception is thrown when an array of four values are provided for point type field. Signed-off-by: Heemin Kim <heemin@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4900 +/- ##
============================================
- Coverage 70.74% 70.73% -0.02%
- Complexity 57859 57865 +6
============================================
Files 4689 4689
Lines 276913 276913
Branches 40301 40301
============================================
- Hits 195912 195867 -45
- Misses 64780 64875 +95
+ Partials 16221 16171 -50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
reta
approved these changes
Oct 25, 2022
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4900-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0f477a2d0aae4d75313a7f26407cda8594bd981e
# Push it to GitHub
git push --set-upstream origin backport/backport-4900-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
heemin32
added a commit
to heemin32/OpenSearch
that referenced
this pull request
Oct 25, 2022
…ensearch-project#4900) With this commit, appropriate exception is thrown when an array of four values are provided for point type field. Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit 0f477a2)
Merged
6 tasks
heemin32
added a commit
to heemin32/OpenSearch
that referenced
this pull request
Oct 25, 2022
…ensearch-project#4900) With this commit, appropriate exception is thrown when an array of four values are provided for point type field. Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit 0f477a2)
heemin32
added a commit
to heemin32/OpenSearch
that referenced
this pull request
Oct 25, 2022
…ensearch-project#4900) With this commit, appropriate exception is thrown when an array of four values are provided for point type field. Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit 0f477a2)
6 tasks
ashking94
pushed a commit
to ashking94/OpenSearch
that referenced
this pull request
Nov 7, 2022
…ensearch-project#4900) With this commit, appropriate exception is thrown when an array of four values are provided for point type field. Signed-off-by: Heemin Kim <heemin@amazon.com> Signed-off-by: Heemin Kim <heemin@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit, appropriate exception is thrown when an array of four values are provided for point type field.
Signed-off-by: Heemin Kim heemin@amazon.com
Description
#4597 introduced a bug which accept an array of four values for point type field. This PR resolve the issue.
Current behavior:
Expected behavior after this commit:
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.