[2.x] Change the version to remove deprecated code of adding node name into log pattern of log4j property file#4569
Merged
tlfeng merged 2 commits intoopensearch-project:2.xfrom Sep 22, 2022
Conversation
added 2 commits
September 21, 2022 23:28
… log pattern of log4j property file Signed-off-by: Tianli Feng <ftianli@amazon.com>
Signed-off-by: Tianli Feng <ftianli@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #4569 +/- ##
============================================
+ Coverage 70.62% 70.76% +0.14%
- Complexity 57085 57200 +115
============================================
Files 4585 4585
Lines 274514 274514
Branches 40229 40229
============================================
+ Hits 193866 194259 +393
+ Misses 64414 64022 -392
+ Partials 16234 16233 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6 tasks
andrross
approved these changes
Sep 22, 2022
Contributor
Author
|
@andrross Thank you for your review! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A following PR of #4568, please see detailed description there.
The part of code is introduced by elastic/elasticsearch@2245957.
The main purpose of the commit is to make the node name available to all loggers all the time, aims make the way of getting logger unified and simple.
There is temporary code added to help users migrate to the new usage of getting node name in log, by scanning the specific pattern setting in log4j.properties files and add the node name into the pattern. A warning message is also added to notify the removal of the temporary code.
3.0from7.0that shown in the warning message.Issues Resolved
Related to #4274
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.