[Segment Replication] Fix possible flaky test for testBeforeIndexShardClosed_CancelsOngoingReplications() by Rishikesh1159 · Pull Request #3963 · opensearch-project/OpenSearch

Rishikesh1159 · 2022-07-20T20:53:05Z

Description

This PR fixes possible flaky test failure for testBeforeIndexShardClosed_CancelsOngoingReplications() by adding null check

Issues Resolved

Related to #3872

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

…rviceTests Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

…cating() test case Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

…to main Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

github-actions · 2022-07-20T21:09:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: ABORTED ❌
URL: https://build.ci.opensearch.org/job/gradle-check/823/
CommitID: e63e907

github-actions · 2022-07-20T21:09:59Z

Gradle Check (Jenkins) Run Completed with:

RESULT: ABORTED ❌
URL: https://build.ci.opensearch.org/job/gradle-check/825/
CommitID: 37438ed

github-actions · 2022-07-20T21:38:45Z

Gradle Check (Jenkins) Run Completed with:

RESULT: ABORTED ❌
URL: https://build.ci.opensearch.org/job/gradle-check/827/
CommitID: 37438ed

github-actions · 2022-07-20T21:48:10Z

Gradle Check (Jenkins) Run Completed with:

RESULT: ABORTED ❌
URL: https://build.ci.opensearch.org/job/gradle-check/830/
CommitID: 37438ed

kartg · 2022-07-20T22:47:10Z

server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java

    private void start(final long replicationId) {
        try (ReplicationRef<SegmentReplicationTarget> replicationRef = onGoingReplications.get(replicationId)) {
+            if (replicationRef == null) {
+                logger.trace("Cannot find any running replication with id [{}]", replicationId);


I don't think a log line is necessary here. Just include a comment that this is for handling edge cases where the reference is removed before the ReplicationRunner is started by the threadpool.

github-actions · 2022-07-20T23:13:59Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/843/
CommitID: 37438ed

codecov-commenter · 2022-07-20T23:16:17Z

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.50%. Comparing base (4466a1f) to head (b58e19e).
⚠️ Report is 4767 commits behind head on main.

Files with missing lines	Patch %	Lines
...s/replication/SegmentReplicationTargetService.java	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3963      +/-   ##
============================================
- Coverage     70.68%   70.50%   -0.18%     
+ Complexity    56835    56721     -114     
============================================
  Files          4573     4573              
  Lines        273255   273258       +3     
  Branches      40076    40078       +2     
============================================
- Hits         193143   192655     -488     
- Misses        63871    64418     +547     
+ Partials      16241    16185      -56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

github-actions · 2022-07-20T23:55:00Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/851/
CommitID: b58e19e

…Replications() (opensearch-project#3963) * Fixing flaky test failure happening for testShardAlreadyReplicating() Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

…#3943 #3963 From main branch (#4181) * Resolving import conflict in Node.java and mergining PR #3525. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Resolving conflicts and merging PR #3533. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Resolving conflicts and Merging PR #3540. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Applying spotlesscheck and fixing wildcard imports. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * [Segment Replication] Fixing flaky test failure happening for testShardAlreadyReplicating() (#3943) * Fixing flaky test failure happening for testShardAlreadyReplicating() Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Fix possible flaky test for testBeforeIndexShardClosed_CancelsOngoingReplications() (#3963) * Fixing flaky test failure happening for testShardAlreadyReplicating() Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Removing assert segrep() in getProcessedLocalCheckpoint() of Index.shard class. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adding back assert statement and make index setting to segment replication in SegmentReplicationSourceHandlerTests and SegmentReplicationTargetServiceTests. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Revert "Adding back assert statement and make index setting to segment replication in SegmentReplicationSourceHandlerTests and SegmentReplicationTargetServiceTests." Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> This reverts commit 8c5753b. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> Co-authored-by: Marc Handalian <handalm@amazon.com> Co-authored-by: Poojita Raj <poojiraj@amazon.com>

Rishikesh1159 and others added 7 commits July 19, 2022 06:05

Fixing flaky test failure happening for testShardAlreadyReplicating()

683880c

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Fixing incorrect import statement in class SegmentReplicationTargetSe…

571d49e

…rviceTests Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Merge branch 'main' into main

f93d316

Changing variable names and adding comments for testShardAlreadyRepli…

96dc44f

…cating() test case Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Merge branch 'main' of https://github.com/Rishikesh1159/OpenSearch in…

076f0ab

…to main Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Merge branch 'opensearch-project:main' into main

47b7609

Add null check to replicationRef when start() called

e63e907

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Rishikesh1159 requested review from a team and reta as code owners July 20, 2022 20:53

Apply spotlessCheck

37438ed

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

kartg reviewed Jul 20, 2022

View reviewed changes

kartg approved these changes Jul 20, 2022

View reviewed changes

Removing log statement and adding comment for null check in start()

b58e19e

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

dreamer-89 approved these changes Jul 21, 2022

View reviewed changes

Rishikesh1159 merged commit 8b5a10c into opensearch-project:main Jul 21, 2022

Rishikesh1159 changed the title ~~Fix possible flaky test for testBeforeIndexShardClosed_CancelsOngoingReplications()~~ [Segment Replication] Fix possible flaky test for testBeforeIndexShardClosed_CancelsOngoingReplications() Jul 21, 2022

Rishikesh1159 mentioned this pull request Aug 10, 2022

[Backport 2.x] [Segment Replication] Backport PR's : #3525 #3533 #3540 #3943 #3963 From main branch #4181

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Segment Replication] Fix possible flaky test for testBeforeIndexShardClosed_CancelsOngoingReplications()#3963

[Segment Replication] Fix possible flaky test for testBeforeIndexShardClosed_CancelsOngoingReplications()#3963
Rishikesh1159 merged 9 commits intoopensearch-project:mainfrom
Rishikesh1159:fix_flaky_test

Rishikesh1159 commented Jul 20, 2022

Uh oh!

github-actions bot commented Jul 20, 2022

Uh oh!

github-actions bot commented Jul 20, 2022

Uh oh!

github-actions bot commented Jul 20, 2022

Uh oh!

github-actions bot commented Jul 20, 2022

Uh oh!

kartg Jul 20, 2022

Uh oh!

github-actions bot commented Jul 20, 2022

Uh oh!

codecov-commenter commented Jul 20, 2022 •

edited by codecov bot

Loading

Uh oh!

github-actions bot commented Jul 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Rishikesh1159 commented Jul 20, 2022

Description

Issues Resolved

Check List

Uh oh!

github-actions bot commented Jul 20, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Jul 20, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Jul 20, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Jul 20, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

kartg Jul 20, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 20, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov-commenter commented Jul 20, 2022 • edited by codecov bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jul 20, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Jul 20, 2022 •

edited by codecov bot

Loading