[Javadocs] add to o.o.action.admin#3155
Merged
nknize merged 4 commits intoopensearch-project:mainfrom May 4, 2022
Merged
Conversation
Collaborator
|
❌ Gradle Check failure f9da54ce4d55e49b16ee034e2039b5d030a227d3 |
Collaborator
|
❌ Gradle Check failure 2733632ec048a1b8dfb39bcc70ad8a341295a31e |
2733632 to
df8cc9c
Compare
Collaborator
|
❌ Gradle Check failure df8cc9cf34e4620c29c7ffbb25df4baa158cabfd |
Collaborator
|
✅ Gradle Check success 2f93a2721e3e0510789f4ce0afdc979c4a91dd11 |
reta
reviewed
May 3, 2022
Contributor
There was a problem hiding this comment.
@nknize do you think we could move these changes to separate pull request (as you did with aliases & types)?
Adds javadocs to classes in package o.o.action.admin and removes unused classes. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
2f93a27 to
0982d86
Compare
reta
approved these changes
May 3, 2022
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3155-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ad1c8038b01d6d82e5393d73bcbf28a43bb97bc2
# Push it to GitHub
git push --set-upstream origin backport/backport-3155-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-3155-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ad1c8038b01d6d82e5393d73bcbf28a43bb97bc2
# Push it to GitHub
git push --set-upstream origin backport/backport-3155-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0Then, create a pull request where the |
saratvemulapalli
pushed a commit
that referenced
this pull request
May 4, 2022
Adds javadocs to classes in package o.o.action.admin. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
added a commit
to nknize/OpenSearch
that referenced
this pull request
May 13, 2022
Adds javadocs to classes in package o.o.action.admin. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
This was referenced May 13, 2022
nknize
added a commit
that referenced
this pull request
May 13, 2022
nknize
added a commit
to nknize/OpenSearch
that referenced
this pull request
May 13, 2022
Adds javadocs to classes in package o.o.action.admin. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
added a commit
that referenced
this pull request
May 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds javadocs to classes in package o.o.action.admin and removes unused classes. Also
adds custom javadoc tags
opensearch.internal,opensearch.experimental, andopensearch.apirelates #221
relates #2868