Add benchmark configs to support intra segment on open PR by prudhvigodithi · Pull Request #20479 · opensearch-project/OpenSearch

prudhvigodithi · 2026-01-26T16:47:04Z

Description

Add benchmark configs to support intra segment, more details #19704

Related Issues

Related to #19694 and part of #18851.

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

coderabbitai · 2026-01-26T16:47:59Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🔍 Trigger a full review

📝 Walkthrough

Walkthrough

Two new benchmark configurations added to define intra-segment test procedures for big5 and http_logs workloads with auto concurrent segment search mode and cluster settings.

Changes

Cohort / File(s)	Summary
Benchmark Configuration Additions `\.github/benchmark-configs.json`	Added two new configuration blocks (id_13, id_14) defining intra-segment test procedures with concurrent segment search mode set to auto; includes cluster-benchmark-configs, cluster_configuration, and baseline_cluster_config entries for big5 and http_logs workloads (+38 lines)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

skip-changelog

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Add benchmark configs to support intra segment on open PR' is related to the main change but is vague and unclear. The phrase 'on open PR' is confusing and appears unrelated to the actual changeset about adding benchmark configurations.	Clarify the title to remove 'on open PR' and be more specific, e.g., 'Add benchmark configurations for intra-segment search' or 'Add intra-segment benchmark configurations'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description provides the required sections with meaningful content: a clear description referencing related PR for more details, related issues identified, and completed checklist acknowledgments.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In @.github/benchmark-configs.json:
- Around line 227-245: The baseline config for id_14 mismatches the snapshot
shard count: WORKLOAD_PARAMS.snapshot_name is "http_logs_3_shards" but
baseline_cluster_config is "x64-c5.2xlarge-1-shard-0-replica-snapshot-baseline";
update baseline_cluster_config to the corresponding 3-shard baseline (e.g., a
name following the 3-shard snapshot pattern) or, if the intent was a 1-shard
baseline, update WORKLOAD_PARAMS.snapshot_name to the correct 1-shard snapshot
and verify snapshot_base_path "10.3.2" is correct for the chosen snapshot;
ensure id_14's baseline_cluster_config and WORKLOAD_PARAMS.snapshot_name are
consistent.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 672039d and b032356.

📒 Files selected for processing (1)

.github/benchmark-configs.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)

GitHub Check: precommit (21, windows-latest)
GitHub Check: precommit (25, windows-latest)
GitHub Check: precommit (25, macos-15-intel)
GitHub Check: precommit (25, ubuntu-24.04-arm)
GitHub Check: precommit (21, macos-15-intel)
GitHub Check: precommit (21, macos-15)
GitHub Check: precommit (21, ubuntu-24.04-arm)
GitHub Check: precommit (21, ubuntu-latest)
GitHub Check: assemble (25, ubuntu-latest)
GitHub Check: precommit (25, macos-15)
GitHub Check: assemble (21, ubuntu-24.04-arm)
GitHub Check: precommit (25, ubuntu-latest)
GitHub Check: precommit (21, windows-2025, true)
GitHub Check: assemble (21, ubuntu-latest)
GitHub Check: assemble (25, windows-latest)
GitHub Check: assemble (25, ubuntu-24.04-arm)
GitHub Check: assemble (21, windows-latest)
GitHub Check: detect-breaking-change
GitHub Check: Analyze (java)

🔇 Additional comments (1)

.github/benchmark-configs.json (1)

208-226: LGTM for id_13 configuration.

The new intra-segment benchmark config for big5 workload is well-structured and consistent with existing patterns. The snapshot name ("big5_1_shard_single_client") aligns with the baseline config naming convention, and the DATA_INSTANCE_TYPE ("c5.2xlarge") matches the baseline cluster config reference.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

.github/benchmark-configs.json

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

prudhvigodithi · 2026-01-26T16:59:42Z

This should be in par with the nightly configuration opensearch-project/opensearch-build#5932 (comment).

.github/benchmark-configs.json

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

jainankitk

I am wondering if it is better to have support for providing the config parameters as part of the run to not create new configurations for each new parameter.

jainankitk · 2026-01-27T00:05:49Z

.github/benchmark-configs.json

    "baseline_cluster_config": "x64-r5.xlarge-1-shard-0-replica-snapshot-baseline"
+  },
+  "id_13": {
+    "description": "Intra-segment search test-procedure for big5 with concurrent segment search mode as auto",


Does this duplicate id_8 configuration?

Similar discussion in past #18353 (comment). The id_13 is to test only with intra-segment test procedure. With inputs we can have one id and multiple such configurations.

…-project#20479) * Add benchmark configs Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Add benchmark configs Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * test almalinux:9 Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * test almalinux:8 Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Update to r5 Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

Add benchmark configs

b032356

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

prudhvigodithi requested review from a team, jed326 and peternied as code owners January 26, 2026 16:47

prudhvigodithi added the skip-changelog label Jan 26, 2026

prudhvigodithi self-assigned this Jan 26, 2026

prudhvigodithi added this to Performance Roadmap Jan 26, 2026

github-project-automation bot moved this to Todo in Performance Roadmap Jan 26, 2026

coderabbitai bot reviewed Jan 26, 2026

View reviewed changes

.github/benchmark-configs.json Show resolved Hide resolved

Add benchmark configs

1c0eddc

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

rishabh6788 reviewed Jan 26, 2026

View reviewed changes

.github/benchmark-configs.json Outdated Show resolved Hide resolved

prudhvigodithi added 2 commits January 26, 2026 10:28

test almalinux:9

e0cdd52

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

test almalinux:8

00c2f40

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

prudhvigodithi mentioned this pull request Jan 26, 2026

Update to almalinux:10 #20482

Merged

3 tasks

prudhvigodithi changed the title ~~Add benchmark configs to support intra segment~~ Add benchmark configs to support intra segment on open PR Jan 26, 2026

prudhvigodithi mentioned this pull request Jan 26, 2026

Implementation for enabling intra-segment search #19704

Merged

3 tasks

prudhvigodithi added 2 commits January 26, 2026 14:13

Merge remote-tracking branch 'upstream/main' into benchmark

d1691fb

Update to r5

7983287

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

rishabh6788 approved these changes Jan 26, 2026

View reviewed changes

mch2 approved these changes Jan 27, 2026

View reviewed changes

github-project-automation bot moved this from Todo to In Progress in Performance Roadmap Jan 27, 2026

prudhvigodithi merged commit d864716 into opensearch-project:main Jan 27, 2026
32 of 54 checks passed

github-project-automation bot moved this from In Progress to Done in Performance Roadmap Jan 27, 2026

jainankitk reviewed Jan 27, 2026

View reviewed changes

coderabbitai bot mentioned this pull request Jan 27, 2026

refresh benchmark configs for intra-segment runs #20492

Merged

This was referenced Feb 5, 2026

[Benchmark PR Configs] Add id_15 with big5 force intra segment partition strategy #20557

Merged

Intra segment support for single-value metric aggregations #20503

Merged

opensearch-ci-bot mentioned this pull request Feb 18, 2026

[AUTOCUT] Gradle Check Flaky Test Report for RemoteRoutingTableServiceTests #14559

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add benchmark configs to support intra segment on open PR#20479

Add benchmark configs to support intra segment on open PR#20479
prudhvigodithi merged 6 commits intoopensearch-project:mainfrom
prudhvigodithi:benchmark

prudhvigodithi commented Jan 26, 2026

Uh oh!

coderabbitai bot commented Jan 26, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

Estimated code review effort

Suggested labels

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

prudhvigodithi commented Jan 26, 2026

Uh oh!

Uh oh!

Uh oh!

jainankitk left a comment

Uh oh!

jainankitk Jan 27, 2026

Uh oh!

prudhvigodithi Jan 27, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

prudhvigodithi commented Jan 26, 2026

Description

Related Issues

Check List

Uh oh!

coderabbitai bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Suggested labels

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

prudhvigodithi commented Jan 26, 2026

Uh oh!

Uh oh!

Uh oh!

jainankitk left a comment

Choose a reason for hiding this comment

Uh oh!

jainankitk Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

prudhvigodithi Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Jan 26, 2026 •

edited

Loading

prudhvigodithi Jan 27, 2026 •

edited

Loading