Skip to content

[AUTO] [main] Add bwc version 2.19.6.#20274

Merged
andrross merged 2 commits intomainfrom
create-pull-request/patch-main
Mar 17, 2026
Merged

[AUTO] [main] Add bwc version 2.19.6.#20274
andrross merged 2 commits intomainfrom
create-pull-request/patch-main

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Dec 17, 2025

I've noticed that a new tag 2.19.5 was pushed, and added a bwc version 2.19.6.

@github-actions github-actions bot requested a review from a team as a code owner December 17, 2025 16:02
@github-actions github-actions bot mentioned this pull request Dec 17, 2025
2 tasks
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 17, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jan 17, 2026
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the create-pull-request/patch-main branch from b5651d5 to 1cb3f8e Compare March 13, 2026 18:29
@opensearch-trigger-bot opensearch-trigger-bot bot changed the title [AUTO] [main] Add bwc version 3.4.1. [AUTO] [main] Add bwc version 2.19.6. Mar 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor Author

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit 1cb3f8e.

PathLineSeverityDescription
libs/core/src/main/java/org/opensearch/Version.java130highVersion ID for V_2_19_6 is '20190699' (8 digits) instead of the expected '2190699' (7 digits), deviating from the consistent encoding pattern used by all neighboring versions (V_2_19_3=2190399, V_2_19_4=2190499, V_2_19_5=2190599). The inflated ID (20,190,699) is numerically greater than V_3_2_0 (3,020,099), meaning any version-gated logic that compares against V_2_19_6 will behave incorrectly — potentially bypassing version checks, breaking BWC compatibility guards, or causing nodes to misreport their version during cluster negotiation. Whether a typo or deliberate, the impact on version comparison logic is significant and warrants close review of all callsites that reference this constant.

The table above displays the top 10 most important findings.

Total: 1 | Critical: 0 | High: 1 | Medium: 0 | Low: 0


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Mar 13, 2026

PR Reviewer Guide 🔍

(Review updated until commit 252c9cd)

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

Lucene Version

The new version V_2_19_6 reuses LUCENE_9_12_3, same as V_2_19_5. This should be verified to ensure no newer Lucene patch version is required for 2.19.6.

public static final Version V_2_19_6 = new Version(2190699, org.apache.lucene.util.Version.LUCENE_9_12_3);

@github-actions
Copy link
Copy Markdown
Contributor Author

❌ Gradle check result for ff6c5c3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor Author

❌ Gradle check result for ff6c5c3: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor Author

❌ Gradle check result for ff6c5c3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross andrross force-pushed the create-pull-request/patch-main branch from ff6c5c3 to 0656e64 Compare March 16, 2026 18:24
@github-actions
Copy link
Copy Markdown
Contributor Author

Persistent review updated to latest commit 0656e64

@andrross andrross force-pushed the create-pull-request/patch-main branch from 0656e64 to 77a4014 Compare March 16, 2026 18:26
@github-actions
Copy link
Copy Markdown
Contributor Author

Persistent review updated to latest commit 77a4014

@github-actions
Copy link
Copy Markdown
Contributor Author

❌ Gradle check result for 77a4014: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

opensearch-ci-bot and others added 2 commits March 16, 2026 14:29
Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross andrross force-pushed the create-pull-request/patch-main branch from 77a4014 to 252c9cd Compare March 16, 2026 21:30
@github-actions
Copy link
Copy Markdown
Contributor Author

Persistent review updated to latest commit 252c9cd

@github-actions
Copy link
Copy Markdown
Contributor Author

❌ Gradle check result for 252c9cd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor Author

❌ Gradle check result for 252c9cd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor Author

✅ Gradle check result for 252c9cd: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.39%. Comparing base (28fa177) to head (252c9cd).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #20274      +/-   ##
============================================
+ Coverage     73.32%   73.39%   +0.06%     
- Complexity    72272    72384     +112     
============================================
  Files          5797     5802       +5     
  Lines        330323   330405      +82     
  Branches      47676    47686      +10     
============================================
+ Hits         242215   242489     +274     
+ Misses        68663    68504     -159     
+ Partials      19445    19412      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit cfebc67 into main Mar 17, 2026
41 of 45 checks passed
@andrross andrross deleted the create-pull-request/patch-main branch March 17, 2026 19:00
@reta reta added the backport 3.5 Backport to 3.5 branch label Mar 20, 2026
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2026
* Add bwc version 2.19.6

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix version

Signed-off-by: Andrew Ross <andrross@amazon.com>

---------

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <83309141+opensearch-ci-bot@users.noreply.github.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit cfebc67)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Mar 23, 2026
* Add bwc version 2.19.6

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix version

Signed-off-by: Andrew Ross <andrross@amazon.com>

---------

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <83309141+opensearch-ci-bot@users.noreply.github.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit cfebc67)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autocut backport 3.5 Backport to 3.5 branch stalled Issues that have stalled

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants