Skip to content

[3.4] Prevent use of shared distribution on gradle builds#20227

Merged
prudhvigodithi merged 2 commits intoopensearch-project:3.4from
dbwiddis:disable-shared-directory
Dec 13, 2025
Merged

[3.4] Prevent use of shared distribution on gradle builds#20227
prudhvigodithi merged 2 commits intoopensearch-project:3.4from
dbwiddis:disable-shared-directory

Conversation

@dbwiddis
Copy link
Copy Markdown
Member

@dbwiddis dbwiddis commented Dec 13, 2025

Description

Prevents use of shared distribution. This conflicts with immutability validation on Gradle 8.6+ in some builds.

This is a temporary fix to unblock 3.4.0 release; see related issue to discuss permanent fix on main.

Related Issues

Temporary fix for #20226

Check List

  • Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbwiddis
Prevent use of shared distribution on gradle builds
b15f5ed 
Signed-off-by: Daniel Widdis <widdis@gmail.com>
@dbwiddis dbwiddis requested a review from a team as a code owner December 13, 2025 04:11
@dbwiddis dbwiddis added the Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. label Dec 13, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 13, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 13, 2025

❌ Gradle check result for b15f5ed: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 13, 2025

❌ Gradle check result for ca47434: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 13, 2025

❌ Gradle check result for ca47434: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 13, 2025

✅ Gradle check result for ca47434: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.29%. Comparing base (62c3bdc) to head (c878d64).
⚠️ Report is 1 commits behind head on 3.4.

Files with missing lines Patch % Lines
...opensearch/gradle/testclusters/OpenSearchNode.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                3.4   #20227   +/-   ##
=========================================
  Coverage     73.29%   73.29%           
+ Complexity    71785    71751   -34     
=========================================
  Files          5794     5794           
  Lines        328218   328218           
  Branches      47261    47261           
=========================================
+ Hits         240554   240564   +10     
+ Misses        68384    68374   -10     
  Partials      19280    19280

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbwiddis
Test the new workaround condition
c878d64 
Signed-off-by: Daniel Widdis <widdis@gmail.com>
@dbwiddis dbwiddis force-pushed the disable-shared-directory branch from ca47434 to c878d64 Compare December 13, 2025 17:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 13, 2025

✅ Gradle check result for c878d64: SUCCESS

@dbwiddis
Copy link
Copy Markdown
Member Author

dbwiddis commented Dec 13, 2025

@opensearch-project/opensearch-core-maintainers This is a quick fix for a bug blocking 3.4.0 release. Please review.

@prudhvigodithi prudhvigodithi merged commit 0033614 into opensearch-project:3.4 Dec 13, 2025
31 of 32 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 13, 2025
@github-actions
[3.4] Prevent use of shared distribution on gradle builds (#20227)
3468bf0 
* Prevent use of shared distribution on gradle builds

Signed-off-by: Daniel Widdis <widdis@gmail.com>

* Test the new workaround condition

Signed-off-by: Daniel Widdis <widdis@gmail.com>

---------

Signed-off-by: Daniel Widdis <widdis@gmail.com>
(cherry picked from commit 0033614)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Dec 13, 2025
Closed
@dbwiddis dbwiddis deleted the disable-shared-directory branch December 13, 2025 18:30
This was referenced Feb 18, 2026
Open
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msfroh msfroh msfroh approved these changes

@prudhvigodithi prudhvigodithi prudhvigodithi approved these changes

Assignees

No one assigned

Labels

backport main Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbwiddis @msfroh @prudhvigodithi