Skip to content

[GRPC] Implement GRPC Search params Highlightand Sort#19868

Merged
karenyrx merged 9 commits intoopensearch-project:mainfrom
lucy66hw:0.23.0-sort-hightlight
Nov 5, 2025
Merged

[GRPC] Implement GRPC Search params Highlightand Sort#19868
karenyrx merged 9 commits intoopensearch-project:mainfrom
lucy66hw:0.23.0-sort-hightlight

Conversation

@lucy66hw
Copy link
Copy Markdown
Contributor

@lucy66hw lucy66hw commented Nov 2, 2025

Description

[GRPC] Implement GRPC Search params Highlightand Sort

Related Issues

part of #19526

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: lucy66hw <fridalu66@gmail.com>
Signed-off-by: xil <fridalu66@gmail.com>
Signed-off-by: xil <fridalu66@gmail.com>
Signed-off-by: xil <fridalu66@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 2, 2025

❌ Gradle check result for 8d3ab91: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@lucy66hw lucy66hw marked this pull request as ready for review November 3, 2025 03:22
@lucy66hw lucy66hw requested a review from a team as a code owner November 3, 2025 03:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 3, 2025

❌ Gradle check result for 8d3ab91: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: xil <fridalu66@gmail.com>
Signed-off-by: Xi Lu <fridalu66@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2025

❌ Gradle check result for 9939c35: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: xil <fridalu66@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2025

❌ Gradle check result for 08ab90d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2025

❌ Gradle check result for 08ab90d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: xil <fridalu66@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2025

✅ Gradle check result for 91f1a41: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 87.29097% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.22%. Comparing base (db72ca2) to head (834ab68).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...oto/request/search/HighlightBuilderProtoUtils.java 79.33% 12 Missing and 13 partials ⚠️
...request/search/sort/GeoDistanceSortProtoUtils.java 90.32% 4 Missing and 2 partials ⚠️
...oto/request/search/sort/SortBuilderProtoUtils.java 87.80% 2 Missing and 3 partials ⚠️
...equest/search/sort/FieldSortBuilderProtoUtils.java 94.73% 0 Missing and 1 partial ⚠️
...roto/request/search/sort/NestedSortProtoUtils.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19868      +/-   ##
============================================
+ Coverage     73.09%   73.22%   +0.13%     
- Complexity    71062    71367     +305     
============================================
  Files          5754     5770      +16     
  Lines        325260   325849     +589     
  Branches      47036    47195     +159     
============================================
+ Hits         237736   238618     +882     
+ Misses        68383    68014     -369     
- Partials      19141    19217      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: xil <fridalu66@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 5, 2025

❌ Gradle check result for f322ae8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@lucy66hw lucy66hw closed this Nov 5, 2025
@lucy66hw lucy66hw reopened this Nov 5, 2025
Signed-off-by: xil <fridalu66@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 5, 2025

❌ Gradle check result for 834ab68: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@lucy66hw lucy66hw closed this Nov 5, 2025
@lucy66hw lucy66hw reopened this Nov 5, 2025
@lucy66hw lucy66hw marked this pull request as draft November 5, 2025 07:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 5, 2025

✅ Gradle check result for 834ab68: SUCCESS

@lucy66hw lucy66hw requested a review from karenyrx November 5, 2025 16:32
@lucy66hw lucy66hw marked this pull request as ready for review November 5, 2025 16:33
@karenyrx karenyrx merged commit 4f519f9 into opensearch-project:main Nov 5, 2025
64 of 66 checks passed
liuguoqingfz pushed a commit to liuguoqingfz/OpenSearch that referenced this pull request Dec 15, 2025
…-project#19868)

* [GRPC] Support Sort and Highlight

Signed-off-by: lucy66hw <fridalu66@gmail.com>
Signed-off-by: xil <fridalu66@gmail.com>

* update changelog

Signed-off-by: xil <fridalu66@gmail.com>

* spotlessApply

Signed-off-by: xil <fridalu66@gmail.com>

* Add ut

Signed-off-by: xil <fridalu66@gmail.com>

* spotlessApply

Signed-off-by: xil <fridalu66@gmail.com>

* address comment

Signed-off-by: xil <fridalu66@gmail.com>

* Add UT

Signed-off-by: xil <fridalu66@gmail.com>

* revert back Highlight

Signed-off-by: xil <fridalu66@gmail.com>

---------

Signed-off-by: lucy66hw <fridalu66@gmail.com>
Signed-off-by: xil <fridalu66@gmail.com>
Signed-off-by: Xi Lu <fridalu66@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants