Change the default value of doc_values in WildcardFieldMapper to true#19796
Merged
kkewwei merged 4 commits intoopensearch-project:mainfrom Oct 30, 2025
Merged
Conversation
000e887 to
81f4999
Compare
Contributor
|
❌ Gradle check result for 81f4999: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei <kkewwei@163.com>
b0cc10f to
d3e2673
Compare
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19796 +/- ##
============================================
+ Coverage 73.11% 73.16% +0.05%
- Complexity 71116 71137 +21
============================================
Files 5754 5754
Lines 325296 325296
Branches 47052 47052
============================================
+ Hits 237824 238003 +179
+ Misses 68328 68105 -223
- Partials 19144 19188 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msfroh
approved these changes
Oct 29, 2025
msfroh
reviewed
Oct 29, 2025
rest-api-spec/src/main/resources/rest-api-spec/test/search/270_wildcard_fieldtype_queries.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>
Contributor
|
❌ Gradle check result for dda919a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Michael Froh <msfroh@apache.org>
Contributor
|
❕ Gradle check result for f79e947: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
anandpatel9998
pushed a commit
to anandpatel9998/OpenSearch
that referenced
this pull request
Nov 3, 2025
…opensearch-project#19796) * Change the default value of doc_values in WildcardFieldMapper to true Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> * fix unit test Signed-off-by: kkewwei <kkewwei@163.com> * change the skip version Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> --------- Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> Signed-off-by: Michael Froh <msfroh@apache.org> Co-authored-by: Michael Froh <msfroh@apache.org>
liuguoqingfz
pushed a commit
to liuguoqingfz/OpenSearch
that referenced
this pull request
Dec 15, 2025
…opensearch-project#19796) * Change the default value of doc_values in WildcardFieldMapper to true Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> * fix unit test Signed-off-by: kkewwei <kkewwei@163.com> * change the skip version Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> --------- Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> Signed-off-by: Michael Froh <msfroh@apache.org> Co-authored-by: Michael Froh <msfroh@apache.org>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently,
WildcardFieldMapperhasdoc_valuesset tofalseby default. This default configuration triggers unnecessary exceptions. Also to align with the default settings of other mappings, we will change the default value ofdoc_valuesto true.As we always serialize this parameter, no matter its value, it's also backward compatibility.
Related Issues
Resolves #18678
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.