Skip to content

Remove LegacyESVersion#19793

Merged
sandeshkr419 merged 10 commits intoopensearch-project:mainfrom
msfroh:clean_up_legacy_es_version
Nov 5, 2025
Merged

Remove LegacyESVersion#19793
sandeshkr419 merged 10 commits intoopensearch-project:mainfrom
msfroh:clean_up_legacy_es_version

Conversation

@msfroh
Copy link
Copy Markdown
Contributor

@msfroh msfroh commented Oct 28, 2025

Description

Since OpenSearch 3.0, we no longer try to maintain backward compatibility with Elasticsearch versions. The LegacyESVersion class is not needed anymore.

Related Issues

Resolves #18387

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added :sanitize Removing elastic specific artifacts backwards-compatibility enhancement Enhancement or improvement to existing feature or request Other labels Oct 28, 2025
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 3352c92: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@msfroh msfroh force-pushed the clean_up_legacy_es_version branch from 3352c92 to 31abbd4 Compare October 28, 2025 10:50
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 31abbd4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@msfroh msfroh force-pushed the clean_up_legacy_es_version branch from 31abbd4 to 74ec295 Compare October 28, 2025 14:47
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 74ec295: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 8cd2c55: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for fa4ef0c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 5b18875: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❕ Gradle check result for f3afd9f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 67.12329% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.13%. Comparing base (46164b5) to head (4fa0b7d).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ibs/core/src/main/java/org/opensearch/Version.java 69.09% 8 Missing and 9 partials ⚠️
.../java/org/opensearch/transport/InboundDecoder.java 55.55% 2 Missing and 2 partials ⚠️
...org/opensearch/cluster/metadata/IndexMetadata.java 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19793      +/-   ##
============================================
- Coverage     73.21%   73.13%   -0.09%     
+ Complexity    71254    71137     -117     
============================================
  Files          5766     5766              
  Lines        325470   325362     -108     
  Branches      47084    47053      -31     
============================================
- Hits         238296   237940     -356     
- Misses        68043    68296     +253     
+ Partials      19131    19126       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 3, 2025

❌ Gradle check result for e91892b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@msfroh msfroh force-pushed the clean_up_legacy_es_version branch from e91892b to 1f28669 Compare November 3, 2025 22:58
Copy link
Copy Markdown
Contributor

@jainankitk jainankitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2025

❌ Gradle check result for 1f28669: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2025

❕ Gradle check result for 1f28669: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

msfroh added 10 commits November 5, 2025 10:18
Since OpenSearch 3.0, we no longer try to maintain backward
compatibility with Elasticsearch versions. The LegacyESVersion class is
not needed anymore.

Signed-off-by: Michael Froh <msfroh@apache.org>
Going forward, any call to `Version.fromId` should pass an OpenSearch
ID, so we should check for the OpenSearch mask.

Signed-off-by: Michael Froh <msfroh@apache.org>
Signed-off-by: Michael Froh <msfroh@apache.org>
Signed-off-by: Michael Froh <msfroh@apache.org>
These tests previously relied on strings with parts going up to 999,
which was never properly supported (since they would overflow into
the next part).

Signed-off-by: Michael Froh <msfroh@apache.org>
Signed-off-by: Michael Froh <msfroh@apache.org>
We need to support handshakes 2 major versions back. For some reason,
this is considered to be 7.9, which is no longer a supported version.

Signed-off-by: Michael Froh <msfroh@apache.org>
Make japicmp happy.

Signed-off-by: Michael Froh <msfroh@apache.org>
Signed-off-by: Michael Froh <msfroh@apache.org>
Signed-off-by: Michael Froh <msfroh@apache.org>
@msfroh msfroh force-pushed the clean_up_legacy_es_version branch from 1f28669 to 4fa0b7d Compare November 5, 2025 18:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 5, 2025

❌ Gradle check result for 4fa0b7d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 5, 2025

✅ Gradle check result for 4fa0b7d: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards-compatibility enhancement Enhancement or improvement to existing feature or request Other :sanitize Removing elastic specific artifacts skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cleanup] Clean up uses of LegacyESVersions

3 participants