Skip to content

[Forwardport main] Fix @timestamp upgrade issue by adding a version check on skip_list param #19677

Merged
sandeshkr419 merged 3 commits intomainfrom
backport/backport-19671-to-main
Oct 22, 2025
Merged

[Forwardport main] Fix @timestamp upgrade issue by adding a version check on skip_list param #19677
sandeshkr419 merged 3 commits intomainfrom
backport/backport-19671-to-main

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Oct 17, 2025

Backport 0b6a2c9 from #19671.

@github-actions @sandeshkr419
Fix @timestamp upgrade issue by adding a version check on skip_list p…
b231c31 
…aram (bwc) (#19671)

Fixes #19660

Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Co-authored-by: Sandesh Kumar <sandeshkr419@gmail.com>
(cherry picked from commit 0b6a2c9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sandeshkr419 sandeshkr419 changed the title [Backport main] Fix @timestamp upgrade issue by adding a version check on skip_list param (3.3) [Backport main] Fix @timestamp upgrade issue by adding a version check on skip_list param Oct 17, 2025
@sandeshkr419 sandeshkr419 added the backport PRs or issues specific to backporting features or enhancments label Oct 17, 2025
@sandeshkr419
Removed changelog of items part of 3.3.1
049e93a 
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
@sandeshkr419
Copy link
Copy Markdown
Member

sandeshkr419 commented Oct 17, 2025 •
edited
Loading

#19671 and #19652 are part of 3.3 branch (upcoming 3.3.1 patch release) so removed it from changelog of main here.

cc: @jainankitk

@jainankitk jainankitk changed the title [Backport main] Fix @timestamp upgrade issue by adding a version check on skip_list param [Forwardport main] Fix @timestamp upgrade issue by adding a version check on skip_list param Oct 17, 2025
jainankitk
jainankitk approved these changes Oct 17, 2025
View reviewed changes
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 17, 2025

❌ Gradle check result for 049e93a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 17, 2025

❌ Gradle check result for 049e93a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Copy Markdown
Contributor

jainankitk commented Oct 17, 2025 

* What went wrong:
Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar'.
> Building 3.3.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/minor/build/bwc/checkout-3.3/distribution/archives/linux-tar/build/distributions/opensearch-min-3.3.0-SNAPSHOT-linux-x64.tar.gz

Probably one of the version related PR needs to merge first for resolving gradle check

@asimmahmood1 asimmahmood1 mentioned this pull request Oct 21, 2025
Closed
3 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 21, 2025

❌ Gradle check result for 049e93a: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peterzhuamazon
Copy link
Copy Markdown
Member

peterzhuamazon commented Oct 21, 2025

Rebased on #19703

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 21, 2025

❌ Gradle check result for 4fe914b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 21, 2025

❌ Gradle check result for 4fe914b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 22, 2025

✅ Gradle check result for 4fe914b: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.12%. Comparing base (3ffa49a) to head (4fe914b).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...a/org/opensearch/index/mapper/DateFieldMapper.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #19677      +/-   ##
============================================
+ Coverage     73.07%   73.12%   +0.05%     
- Complexity    70741    70831      +90     
============================================
  Files          5732     5732              
  Lines        324140   324141       +1     
  Branches      46922    46923       +1     
============================================
+ Hits         236853   237030     +177     
+ Misses        68117    67991     -126     
+ Partials      19170    19120      -50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandeshkr419 sandeshkr419 merged commit 1173bdf into main Oct 22, 2025
35 of 39 checks passed
@sandeshkr419 sandeshkr419 deleted the backport/backport-19671-to-main branch October 22, 2025 05:27
This was referenced Oct 22, 2025
Open
Open
Open
Closed
kh3ra pushed a commit to kh3ra/OpenSearch that referenced this pull request Oct 23, 2025
@opensearch-trigger-bot @github-actions
@sandeshkr419 @peterzhuamazon
[Forwardport main] Fix @timestamp upgrade issue by adding a version c…
6296cb4 
…heck on skip_list param (opensearch-project#19677)

* Fix @timestamp upgrade issue by adding a version check on skip_list param (bwc) (opensearch-project#19671)

Fixes opensearch-project#19660

Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Co-authored-by: Sandesh Kumar <sandeshkr419@gmail.com>
(cherry picked from commit 0b6a2c9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Removed changelog of items part of 3.3.1

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>

---------

Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sandesh Kumar <sandeshkr419@gmail.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandeshkr419 sandeshkr419 sandeshkr419 left review comments

@jainankitk jainankitk jainankitk approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

Assignees

No one assigned

Labels

backport PRs or issues specific to backporting features or enhancments

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sandeshkr419 @jainankitk @peterzhuamazon