Introduced monitoring mode for query string query max length.#19539
Conversation
Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com>
ac1cdd7 to
377eca4
Compare
|
❌ Gradle check result for 377eca4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Tagging @cwperks , @jainankitk for a review. |
|
@kkhatua I'm not really in favor of one-off settings like this. The max-length setting introduced in #19491 is already changeable dynamically. What do you think about making any responses that exceed the configured max length to be actionable? i.e. the response should not just be that the request fails, but state the reason for failure and how to adjust the max length setting. This is from one of the tests:
Maybe we can specify the setting name in that message? |
yeah having a failure reason would be useful. |
|
Agree on providing a failure reason with the settings to modify, similar to other settings. Tagging @jainankitk to review. Would be good to have this for 3.3 release, but it's not a must. |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
Fixed the conflicts due to the CHANGELOG being cleared. The content of this change looks good to me. I was comparing this more to XContentConstraint where there is a max enforced in the Jackson library itself. Similar to Lucene BoolQuery with 1024 max clause count:
|
|
@jainankitk given that we're only supporting it as a |
|
This PR is stalled because it has been open for 30 days with no activity. |
|
❌ Gradle check result for 25b7541: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 25b7541: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Failed due to flaky test: Retrying gradle check |
Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 325cf30) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
#20195) (cherry picked from commit 325cf30) Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Craig Perkins <cwperx@amazon.com>
…arch-project#19539) Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Craig Perkins <cwperx@amazon.com>
…arch-project#19539) Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Craig Perkins <cwperx@amazon.com>
…arch-project#19539) Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Craig Perkins <cwperx@amazon.com>
Description
The PR introduces "query string query" monitoring mode. The mode is by default disabled. If the system administrator enables the mode (using the configuration property
search.query.max_query_string_length_monitor_only), then the OS executes queries that exceed the max length limit and logs an additional warning message.The PR is related to the discussion
Related Issues
#19491 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.