Skip to content

Making Shard Limit Validator Index Tier Agnostic#19532

Merged
gbbafna merged 15 commits intoopensearch-project:mainfrom
Gagan6164:remoteShardLimitValidator
Oct 15, 2025
Merged

Making Shard Limit Validator Index Tier Agnostic#19532
gbbafna merged 15 commits intoopensearch-project:mainfrom
Gagan6164:remoteShardLimitValidator

Conversation

@Gagan6164
Copy link
Copy Markdown
Contributor

@Gagan6164 Gagan6164 commented Oct 6, 2025 •
edited
Loading

Description

Making Shard Limit Validator Index Tier Agnostic

Related Issues

Resolves #19610

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Making Shard Limit Validator Index Tier Agnostic
1f0f270 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@Gagan6164 Gagan6164 requested a review from a team as a code owner October 6, 2025 11:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 6, 2025

❌ Gradle check result for 1f0f270: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Gagan Singh Saini added 3 commits October 6, 2025 18:23
Unit test fixes for Shard Limit allocation decider
e498ecf 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
Merge branch 'main' into remoteShardLimitValidator
c66b548
Fixing breaking changes
9f7a68e 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 6, 2025

❌ Gradle check result for 9f7a68e: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Making Cluster Shard Limit IT parameterized
53d5882 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 7, 2025

❌ Gradle check result for 53d5882: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Gagan Singh Saini and others added 2 commits October 8, 2025 23:45
fixing ingnored IT
d89bb3d 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@Gagan6164
Merge branch 'main' into remoteShardLimitValidator
85ebf51 
Signed-off-by: Gagan6164 <32809202+Gagan6164@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 8, 2025

❌ Gradle check result for 85ebf51: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Shard Limit Allocation Decider IT for warm
219bb74 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2025

✅ Gradle check result for 219bb74: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 86.04651% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.02%. Comparing base (39b7a59) to head (df40850).
⚠️ Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...location/decider/ShardsLimitAllocationDecider.java 71.42% 5 Missing and 3 partials ⚠️
...va/org/opensearch/indices/ShardLimitValidator.java 90.76% 5 Missing and 1 partial ⚠️
...luster/metadata/MetadataUpdateSettingsService.java 70.00% 2 Missing and 1 partial ⚠️
...h/cluster/metadata/MetadataCreateIndexService.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #19532      +/-   ##
============================================
+ Coverage     73.00%   73.02%   +0.01%     
- Complexity    70534    70570      +36     
============================================
  Files          5719     5719              
  Lines        323260   323346      +86     
  Branches      46816    46826      +10     
============================================
+ Hits         235993   236115     +122     
+ Misses        68224    68198      -26     
+ Partials      19043    19033      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gagan6164 Gagan6164 mentioned this pull request Oct 12, 2025
Merged
Resolving comments
83ea736 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 12, 2025

❌ Gradle check result for 83ea736: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search:Searchable Snapshots labels Oct 13, 2025
@Gagan6164 Gagan6164 force-pushed the remoteShardLimitValidator branch from 1c4f7b5 to 3d7d9de Compare October 13, 2025 12:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 13, 2025

✅ Gradle check result for 19efbd1: SUCCESS

ajaymovva
ajaymovva reviewed Oct 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ajaymovva ajaymovva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments. Rest LGTM.

Gagan Singh Saini added 2 commits October 14, 2025 16:36
Resolving comments
e089ffc 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
empty commit to retrigger build
c6b2f3f 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 14, 2025

✅ Gradle check result for c6b2f3f: SUCCESS

gbbafna
gbbafna reviewed Oct 15, 2025
View reviewed changes
Resolving comments
13a4506 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 15, 2025

❌ Gradle check result for 13a4506: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

empty commit to retrigger build
03e7aff 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 15, 2025

❌ Gradle check result for 03e7aff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 15, 2025

❌ Gradle check result for 03e7aff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

fixing failing IT
df40850 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 15, 2025

✅ Gradle check result for df40850: SUCCESS

@gbbafna gbbafna merged commit cb530cf into opensearch-project:main Oct 15, 2025
33 checks passed
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
@Gagan6164
Make Shard Limit Validator Tier specific (opensearch-project#19532)
9185768 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@Gagan6164 Gagan6164 mentioned this pull request Oct 17, 2025
Merged
3 tasks
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Oct 18, 2025
@Gagan6164 @rgsriram
Make Shard Limit Validator Tier specific (opensearch-project#19532)
fd80d5b 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 22, 2025
Open
kh3ra pushed a commit to kh3ra/OpenSearch that referenced this pull request Oct 23, 2025
@Gagan6164
Make Shard Limit Validator Tier specific (opensearch-project#19532)
0294183 
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Nov 7, 2025
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Nov 21, 2025
Open
@BrewTestBot BrewTestBot mentioned this pull request Dec 17, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 30, 2025
Merged
3 tasks
@tkykenmt tkykenmt mentioned this pull request Jan 11, 2026
Closed
3 tasks
@andrross andrross mentioned this pull request Mar 12, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gbbafna gbbafna gbbafna approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz

@andrross andrross Awaiting requested review from andrross

@ashking94 ashking94 Awaiting requested review from ashking94

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE

@cwperks cwperks Awaiting requested review from cwperks

@dbwiddis dbwiddis Awaiting requested review from dbwiddis

@jed326 jed326 Awaiting requested review from jed326

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal

@mch2 mch2 Awaiting requested review from mch2

@msfroh msfroh Awaiting requested review from msfroh

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19

@reta reta Awaiting requested review from reta

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159

@sachinpkale sachinpkale Awaiting requested review from sachinpkale

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli

@shwetathareja shwetathareja Awaiting requested review from shwetathareja

@sohami sohami Awaiting requested review from sohami

+1 more reviewer

@ajaymovva ajaymovva ajaymovva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Enhancement or improvement to existing feature or request Search:Searchable Snapshots

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Making Shard Limit Validator and allocation decider index tier agnostic

3 participants

@Gagan6164 @ajaymovva @gbbafna