Disable request cache for streaming and other fixes#19520
Merged
jainankitk merged 1 commit intoopensearch-project:mainfrom Oct 4, 2025
Merged
Disable request cache for streaming and other fixes#19520jainankitk merged 1 commit intoopensearch-project:mainfrom
jainankitk merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
f8863e8 to
5396dc9
Compare
Contributor
|
❌ Gradle check result for 5396dc9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Oct 4, 2025
Member
|
Manual backport 3.3: #19522 |
bowenlan-amzn
approved these changes
Oct 4, 2025
Member
bowenlan-amzn
left a comment
There was a problem hiding this comment.
I would expect a non-null FlushMode when creating aggregator. Will figure out why later.
Contributor
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19520 +/- ##
============================================
- Coverage 73.09% 72.95% -0.14%
+ Complexity 70553 70458 -95
============================================
Files 5716 5717 +1
Lines 322926 323004 +78
Branches 46770 46784 +14
============================================
- Hits 236032 235639 -393
- Misses 67882 68387 +505
+ Partials 19012 18978 -34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jainankitk
approved these changes
Oct 4, 2025
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Oct 15, 2025
…ct#19520) Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When request is streaming aggregation, we should refrain from caching it due to lack of better solution at present.
Independent of this issue, there are couple of other issues with streaming aggregation which are follow up of #19484 -
Need to check flush mode as null or per segment before deciding on StreamCardinalityAggregator in CardinalityAggregatorFactory.
Minor - When profilingAggregator is enabled, flushMode decision doesn't work as expected.
Min, Max aggregator should be Streamable.
Related Issues
Resolves #19518
Check List
- [ ] API changes companion pull request created, if applicable.- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.