Fix flaky testMaxScoreWithSortOnScoreAndCollapsingResults#19513
Merged
gaobinlong merged 2 commits intoopensearch-project:mainfrom Oct 17, 2025
Merged
Fix flaky testMaxScoreWithSortOnScoreAndCollapsingResults#19513gaobinlong merged 2 commits intoopensearch-project:mainfrom
gaobinlong merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Contributor
|
❕ Gradle check result for 2d9b1d3: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19513 +/- ##
============================================
- Coverage 73.09% 72.98% -0.11%
+ Complexity 70553 70409 -144
============================================
Files 5716 5716
Lines 322926 322926
Branches 46770 46770
============================================
- Hits 236032 235694 -338
- Misses 67882 68221 +339
+ Partials 19012 19011 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@gaobinlong please take a look when you got time |
sandeshkr419
approved these changes
Oct 9, 2025
sandeshkr419
approved these changes
Oct 12, 2025
Contributor
|
Thanks @bowenlan-amzn, by comparing with testCollapseQuerySearchResults(), I found that index sorting is missing in this method, so add an index sorting configuration to the IndexWriter is a better solution? |
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
sandeshkr419
approved these changes
Oct 16, 2025
Contributor
gaobinlong
approved these changes
Oct 17, 2025
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Oct 18, 2025
…-project#19513) * fix flaky testMaxScoreWithSortOnScoreAndCollapsingResults Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * fix flaky testMaxScoreWithSortOnScoreAndCollapsingResults Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Oct 23, 2025
…-project#19513) * fix flaky testMaxScoreWithSortOnScoreAndCollapsingResults Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * fix flaky testMaxScoreWithSortOnScoreAndCollapsingResults Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a flaky test in
QueryPhaseTests.testMaxScoreWithSortOnScoreAndCollapsingResultsthat fails intermittently with certain random seeds, likeA86CC83E4E8823F2.Example failure: https://build.ci.opensearch.org/job/gradle-check/64947/testReport/junit/org.opensearch.search.query/QueryPhaseTests/testMaxScoreWithSortOnScoreAndCollapsingResults__p0_5_p1_org_opensearch_search_query_ConcurrentQueryPhaseSearcher_1f6ba47b_/
Test came from #19181
The test was making order-dependent assertions on collapsed search results:
However, the order of collapsed results is non-deterministic when documents have equal scores because:
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.