fix fieldtypeinferencetest#19510
Conversation
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
|
@rishabhmaurya for your review |
|
@harshavamsi makes sense. Do we know why it started failing post upgrade? |
|
@rishabhmaurya I believe it is coming from apache/lucene#14823. previously we could have 10 segments in the tier which this test has, but now we are merging at 8 which means in this test the segments do get merged. we no longer see 1k docs per segment |
|
❌ Gradle check result for b52881c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b52881c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19510 +/- ##
============================================
+ Coverage 73.01% 73.05% +0.03%
- Complexity 70422 70435 +13
============================================
Files 5712 5712
Lines 322764 322764
Branches 46743 46743
============================================
+ Hits 235673 235781 +108
+ Misses 68078 67993 -85
+ Partials 19013 18990 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't think it requires a 3.3 backport given its a test fix |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Description
Fixes the test to check for actual docs in the leaf compared to the hard coded value. This is more correct since we're evaluating against docs in each leaf
Related Issues
Resolves #19334
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.