[Rule-based Auto-tagging] bug fix on Update Rule API with multiple attributes#19497
Merged
jainankitk merged 1 commit intoopensearch-project:mainfrom Oct 2, 2025
Merged
Conversation
Contributor
|
❌ Gradle check result for f6eabf7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
Test failures look related: @ruai0511 - Can you check once? |
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
jainankitk
approved these changes
Oct 1, 2025
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19497 +/- ##
============================================
- Coverage 73.07% 72.95% -0.12%
+ Complexity 70414 70392 -22
============================================
Files 5708 5711 +3
Lines 322502 322587 +85
Branches 46705 46716 +11
============================================
- Hits 235653 235334 -319
- Misses 67865 68274 +409
+ Partials 18984 18979 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Oct 15, 2025
…ect#19497) Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a bug fix for the Update Rule API used in rule-based auto-tagging.
Previously, if a rule had two attributes and an update request was sent with only one attribute, both existing attributes would be replaced. With this fix, only the specified attribute will be updated, while the others remain unchanged.
For example,
the previous rule is
and we only update the field
index_pattern, the result will still have the original principal entryRelated Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.