Skip to content

[Backport 2.19] Replace commons-lang:commons-lang with org.apache.commons:commons-lang3 (#19229)#19476

Merged
andrross merged 2 commits intoopensearch-project:2.19from
cwperks:backport-19229-to-2.19
Oct 14, 2025
Merged

[Backport 2.19] Replace commons-lang:commons-lang with org.apache.commons:commons-lang3 (#19229)#19476
andrross merged 2 commits intoopensearch-project:2.19from
cwperks:backport-19229-to-2.19

Conversation

@cwperks
Copy link
Copy Markdown
Member

@cwperks cwperks commented Sep 30, 2025

(cherry picked from commit 7651600)

Description

Backport #19229 to 2.19

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks
Replace commons-lang:commons-lang with org.apache.commons:commons-lan…
019bd93 
…g3 (opensearch-project#19229)

* Replace commons-lang:commons-lang with org.apache.commons:commons-lang3

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Create a shim around commons-lang3 StringUtils

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 7651600)
@cwperks cwperks requested review from a team and peternied as code owners September 30, 2025 14:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 30, 2025

❌ Gradle check result for 019bd93: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 30, 2025

❌ Gradle check result for 019bd93: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks
Merge branch '2.19' into backport-19229-to-2.19
08128cd 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented Oct 13, 2025 •
edited
Loading

@andrross @dbwiddis let's also get this one into 2.19

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 13, 2025

❌ Gradle check result for 08128cd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 14, 2025

✅ Gradle check result for 08128cd: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.95%. Comparing base (9057d4c) to head (08128cd).
⚠️ Report is 3 commits behind head on 2.19.

Files with missing lines Patch % Lines
...main/java/org/apache/commons/lang/StringUtils.java 0.00% 10 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               2.19   #19476      +/-   ##
============================================
+ Coverage     71.93%   71.95%   +0.01%     
- Complexity    65945    65996      +51     
============================================
  Files          5341     5342       +1     
  Lines        307273   307283      +10     
  Branches      44845    44845              
============================================
+ Hits         221050   221105      +55     
- Misses        67735    67741       +6     
+ Partials      18488    18437      -51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit b286d2d into opensearch-project:2.19 Oct 14, 2025
44 of 47 checks passed
sokdak pushed a commit to sokdak/OpenSearch that referenced this pull request Oct 15, 2025
@cwperks @sokdak
Replace commons-lang:commons-lang with org.apache.commons:commons-lan…
31e4742 
…g3 (opensearch-project#19229) (opensearch-project#19476)

(cherry picked from commit 7651600)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
This was referenced Oct 22, 2025
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrross andrross andrross approved these changes

@peternied peternied Awaiting requested review from peternied peternied is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cwperks @andrross