Skip to content

[GRPC][Term-level queries] Implement GRPC Ids, Range, and Terms Set queries#19448

Merged
mch2 merged 17 commits intoopensearch-project:mainfrom
karenyrx:0.18.0_bool_ids_range_termsset
Sep 30, 2025
Merged

[GRPC][Term-level queries] Implement GRPC Ids, Range, and Terms Set queries#19448
mch2 merged 17 commits intoopensearch-project:mainfrom
karenyrx:0.18.0_bool_ids_range_termsset

Conversation

@karenyrx
Copy link
Copy Markdown
Contributor

@karenyrx karenyrx commented Sep 29, 2025

Description

Stacked on top of #19447
Implement GRPC Ids, Range, and Terms Set queries

Related Issues

Resolves #18907

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@karenyrx
upgrade to protobufs 0.18.0
28b984c 
Signed-off-by: Karen X <karenxyr@gmail.com>
@github-actions github-actions bot added the enhancement Enhancement or improvement to existing feature or request label Sep 29, 2025
@karenyrx karenyrx mentioned this pull request Sep 29, 2025
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 29, 2025

❌ Gradle check result for 8dbf346: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@karenyrx
add tests
fef4f49 
Signed-off-by: Karen X <karenxyr@gmail.com>
@karenyrx karenyrx force-pushed the 0.18.0_bool_ids_range_termsset branch from 8dbf346 to b7abcfb Compare September 29, 2025 07:27
@karenyrx
[GRPC][Term-level queries] Implement Ids, Range, Termsset
d89048d 
Signed-off-by: Karen X <karenxyr@gmail.com>
@karenyrx karenyrx force-pushed the 0.18.0_bool_ids_range_termsset branch from b7abcfb to d89048d Compare September 29, 2025 07:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 29, 2025

✅ Gradle check result for d89048d: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.26316% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.96%. Comparing base (259add3) to head (47d4726).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...uest/search/query/RangeQueryBuilderProtoUtils.java 93.84% 1 Missing and 7 partials ⚠️
...t/search/query/TermsSetQueryBuilderProtoUtils.java 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #19448      +/-   ##
============================================
+ Coverage     72.88%   72.96%   +0.07%     
- Complexity    70219    70342     +123     
============================================
  Files          5702     5708       +6     
  Lines        322202   322392     +190     
  Branches      46625    46686      +61     
============================================
+ Hits         234832   235226     +394     
+ Misses        68418    68217     -201     
+ Partials      18952    18949       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karenyrx
Merge remote-tracking branch 'ossupstream/main' into 0.18.0_bool_ids_…
d0cbe21 
…range_termsset
@karenyrx
package private
84e5135 
Signed-off-by: Karen X <karenxyr@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 29, 2025

✅ Gradle check result for d0cbe21: SUCCESS

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 29, 2025

✅ Gradle check result for a44d86c: SUCCESS

@karenyrx
remove unused variables
08037b3 
Signed-off-by: Karen X <karenxyr@gmail.com>
@karenyrx karenyrx force-pushed the 0.18.0_bool_ids_range_termsset branch from a44d86c to 08037b3 Compare September 30, 2025 00:48
@karenyrx
Merge branch 'main' into 0.18.0_bool_ids_range_termsset
67aa628 
Signed-off-by: Karen X <karenxyr@gmail.com>
@karenyrx karenyrx marked this pull request as ready for review September 30, 2025 00:50
@karenyrx karenyrx requested a review from a team as a code owner September 30, 2025 00:50
@karenyrx
spotless
cd654aa 
Signed-off-by: Karen X <karenxyr@gmail.com>
@karenyrx
Merge branch 'main' into 0.18.0_bool_ids_range_termsset
70eb7b3 
Signed-off-by: Karen X <karenxyr@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 30, 2025

❌ Gradle check result for 70eb7b3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@karenyrx
remove duplicate from merge conflict
24c230d 
Signed-off-by: Karen X <karenxyr@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 30, 2025

❌ Gradle check result for 24c230d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@karenyrx
Merge branch 'main' into 0.18.0_bool_ids_range_termsset
aef0221 
Signed-off-by: Karen X <karenxyr@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 30, 2025

✅ Gradle check result for aef0221: SUCCESS

@karenyrx
Merge branch 'main' into 0.18.0_bool_ids_range_termsset
ecd6734 
Signed-off-by: Karen X <karenxyr@gmail.com>
@karenyrx
spotless and fix merge conflict
1fb2f8d 
Signed-off-by: Karen X <karenxyr@gmail.com>
@karenyrx karenyrx force-pushed the 0.18.0_bool_ids_range_termsset branch from f9228ff to 1fb2f8d Compare September 30, 2025 18:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 30, 2025

❌ Gradle check result for 1fb2f8d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@karenyrx
Merge branch 'main' into 0.18.0_bool_ids_range_termsset
913402e 
Signed-off-by: Karen X <karenxyr@gmail.com>
@karenyrx
spotless
98cafd2 
Signed-off-by: Karen X <karenxyr@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 30, 2025

❌ Gradle check result for 98cafd2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 30, 2025
Open
@karenyrx
Merge branch 'main' into 0.18.0_bool_ids_range_termsset
fc172c0 
Signed-off-by: Karen X <karenxyr@gmail.com>
@karenyrx
fix merge conflict and spotless
47d4726 
Signed-off-by: Karen X <karenxyr@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 30, 2025

✅ Gradle check result for 47d4726: SUCCESS

@mch2 mch2 merged commit 723f6d5 into opensearch-project:main Sep 30, 2025
33 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 15, 2025
Merged
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
@karenyrx
[GRPC][Term-level queries] Implement GRPC Ids, Range, and Terms Set q…
55c74fb 
…ueries (opensearch-project#19448)

* upgrade to protobufs 0.18.0

Signed-off-by: Karen X <karenxyr@gmail.com>

* add tests

Signed-off-by: Karen X <karenxyr@gmail.com>

* [GRPC][Term-level queries] Implement Ids, Range, Termsset

Signed-off-by: Karen X <karenxyr@gmail.com>

* package private

Signed-off-by: Karen X <karenxyr@gmail.com>

* remove unused variables

Signed-off-by: Karen X <karenxyr@gmail.com>

* spotless

Signed-off-by: Karen X <karenxyr@gmail.com>

* remove duplicate from merge conflict

Signed-off-by: Karen X <karenxyr@gmail.com>

* spotless and fix merge conflict

Signed-off-by: Karen X <karenxyr@gmail.com>

* spotless

Signed-off-by: Karen X <karenxyr@gmail.com>

* fix merge conflict and spotless

Signed-off-by: Karen X <karenxyr@gmail.com>

---------

Signed-off-by: Karen X <karenxyr@gmail.com>
Co-authored-by: karenx <karenx@uber.com>
This was referenced Oct 22, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mch2 mch2 mch2 approved these changes

Assignees

No one assigned

Labels

enhancement Enhancement or improvement to existing feature or request skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] [GRPC][Search] Implement Term-level Query Proto Converters

2 participants

@karenyrx @mch2