Skip to content

Migrate deprecated usages of Operations#union#19397

Merged
andrross merged 4 commits intoopensearch-project:mainfrom
fdesu:feature/migrate-deprecated-operations-union-usages
Sep 26, 2025
Merged

Migrate deprecated usages of Operations#union#19397
andrross merged 4 commits intoopensearch-project:mainfrom
fdesu:feature/migrate-deprecated-operations-union-usages

Conversation

@fdesu
Copy link
Copy Markdown
Contributor

@fdesu fdesu commented Sep 24, 2025

This PR does a minor change to migrate usages of deprecated Lucene Operations#union to a non-deprecated version, preserving the original behaviour.

Description

Migrate usages of org.apache.lucene.util.automaton.Operations#union(Automaton, Automaton) to org.apache.lucene.util.automaton.Operations#union(Collection<Automation>)

Related Issues

None

Check List

  • Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@fdesu fdesu requested a review from a team as a code owner September 24, 2025 16:15
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 409b283: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@fdesu fdesu force-pushed the feature/migrate-deprecated-operations-union-usages branch from d0885b0 to 6856376 Compare September 24, 2025 17:14
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 6856376: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@fdesu
Copy link
Copy Markdown
Contributor Author

fdesu commented Sep 25, 2025

Seems like the gradle-check can't start:

...
WORKFLOW_URL
Job not started yet. Waiting for 60 seconds before next attempt.
time passed: 7260
Please check jenkins url for logs: 
Result: null
Error: Process completed with exit code 1.

could we maybe re-run it?

@fdesu fdesu changed the title Migrate deprecated usages of Operation#union Migrate deprecated usages of Operations#union Sep 25, 2025
@gaobinlong
Copy link
Copy Markdown
Contributor

Reran the checks, could you add a change log for this PR?

Migrate usages of org.apache.lucene.util.automaton.Operations#union(Automaton, Automaton) to Operations#union(Collection<Automation>)

Signed-off-by: Sergei Ustimenko <fdesu@proton.me>
Signed-off-by: fdesu <fdesu@proton.me>
Signed-off-by: Sergei Ustimenko <fdesu@proton.me>
@github-actions
Copy link
Copy Markdown
Contributor

❕ Gradle check result for e8028ff: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.93%. Comparing base (e5d01b5) to head (e72290b).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19397      +/-   ##
============================================
- Coverage     73.03%   72.93%   -0.11%     
+ Complexity    69997    69896     -101     
============================================
  Files          5676     5676              
  Lines        320923   320924       +1     
  Branches      46392    46392              
============================================
- Hits         234396   234050     -346     
- Misses        67610    67921     +311     
- Partials      18917    18953      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fdesu
Copy link
Copy Markdown
Contributor Author

fdesu commented Sep 25, 2025

❕ Gradle check result for e8028ff: UNSTABLE

The UNSTABLE status was reported by the gradle-check task, which indeed failed last time but due to a timeout. I think there's nothing much to do right now.

Signed-off-by: Sergei Ustimenko <fdesu@proton.me>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for e72290b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@fdesu
Copy link
Copy Markdown
Contributor Author

fdesu commented Sep 25, 2025

Yup, the last failure is caused by one of the flaky tests:

> Task :server:test

Tests with failures:
 - org.opensearch.gateway.remote.RemoteClusterStateServiceTests.testReadClusterStateInParallel_ExceptionDuringRead

16547 tests completed, 1 failed, 73 skipped

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for e72290b: SUCCESS

@andrross andrross merged commit 0c882c4 into opensearch-project:main Sep 26, 2025
34 of 36 checks passed
@andrross
Copy link
Copy Markdown
Member

Thanks @fdesu!

karenyrx pushed a commit to karenyrx/OpenSearch that referenced this pull request Sep 29, 2025
Migrate usages of org.apache.lucene.util.automaton.Operations#union(Automaton, Automaton) to Operations#union(Collection<Automation>)

Signed-off-by: Sergei Ustimenko <fdesu@proton.me>
Signed-off-by: fdesu <fdesu@proton.me>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
Migrate usages of org.apache.lucene.util.automaton.Operations#union(Automaton, Automaton) to Operations#union(Collection<Automation>)

Signed-off-by: Sergei Ustimenko <fdesu@proton.me>
Signed-off-by: fdesu <fdesu@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants