Skip to content

Add CompletionStage variants to IndicesAdminClient as an alternative to ActionListener#19161

Merged
cwperks merged 3 commits intoopensearch-project:mainfrom
cwperks:indices-admin-client
Aug 28, 2025
Merged

Add CompletionStage variants to IndicesAdminClient as an alternative to ActionListener#19161
cwperks merged 3 commits intoopensearch-project:mainfrom
cwperks:indices-admin-client

Conversation

@cwperks
Copy link
Copy Markdown
Member

@cwperks cwperks commented Aug 27, 2025

Description

Follow-up to #18998 to apply the same change in IndicesAdminClient.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…to ActionListener

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

❕ Gradle check result for 21f9f85: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 4.65116% with 123 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.01%. Comparing base (f5d41fb) to head (320cf6c).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...pensearch/transport/client/IndicesAdminClient.java 4.65% 123 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19161      +/-   ##
============================================
+ Coverage     72.95%   73.01%   +0.05%     
- Complexity    69701    69763      +62     
============================================
  Files          5655     5656       +1     
  Lines        319867   320002     +135     
  Branches      46337    46338       +1     
============================================
+ Hits         233364   233634     +270     
+ Misses        67584    67443     -141     
- Partials      18919    18925       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 320cf6c: SUCCESS

@cwperks cwperks merged commit cb19e7c into opensearch-project:main Aug 28, 2025
30 of 31 checks passed
atris pushed a commit to atris/OpenSearch that referenced this pull request Aug 28, 2025
…to ActionListener (opensearch-project#19161)

* Add CompletionStage variants to IndicesAdminClient as an alternative to ActionListener

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
pranikum pushed a commit to pranikum/OpenSearch that referenced this pull request Sep 4, 2025
…to ActionListener (opensearch-project#19161)

* Add CompletionStage variants to IndicesAdminClient as an alternative to ActionListener

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
kh3ra pushed a commit to kh3ra/OpenSearch that referenced this pull request Sep 5, 2025
…to ActionListener (opensearch-project#19161)

* Add CompletionStage variants to IndicesAdminClient as an alternative to ActionListener

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
…to ActionListener (opensearch-project#19161)

* Add CompletionStage variants to IndicesAdminClient as an alternative to ActionListener

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
…to ActionListener (opensearch-project#19161)

* Add CompletionStage variants to IndicesAdminClient as an alternative to ActionListener

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
…to ActionListener (opensearch-project#19161)

* Add CompletionStage variants to IndicesAdminClient as an alternative to ActionListener

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
asimmahmood1 pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 23, 2025
…to ActionListener (opensearch-project#19161)

* Add CompletionStage variants to IndicesAdminClient as an alternative to ActionListener

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
…to ActionListener (opensearch-project#19161)

* Add CompletionStage variants to IndicesAdminClient as an alternative to ActionListener

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants