Skip to content

Add skip_list param for date, scaled float and token count fields#19142

Merged
jainankitk merged 1 commit intoopensearch-project:mainfrom
asimmahmood1:skiplist_scalledfloat
Sep 24, 2025
Merged

Add skip_list param for date, scaled float and token count fields#19142
jainankitk merged 1 commit intoopensearch-project:mainfrom
asimmahmood1:skiplist_scalledfloat

Conversation

@asimmahmood1
Copy link
Copy Markdown
Contributor

@asimmahmood1 asimmahmood1 commented Aug 25, 2025

Description

Related Issues

Resolves [#17965]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 64cae12: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for beb9dbe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 572b134: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 72c3c39: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 8ce97fa: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.80%. Comparing base (bb5f0e8) to head (c2ab72a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19142      +/-   ##
============================================
- Coverage     72.84%   72.80%   -0.04%     
+ Complexity    69820    69818       -2     
============================================
  Files          5674     5674              
  Lines        320901   320925      +24     
  Branches      46394    46395       +1     
============================================
- Hits         233751   233649     -102     
- Misses        68269    68404     +135     
+ Partials      18881    18872       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 2e15536: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 2e15536: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 2e15536: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 2e15536: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@asimmahmood1
Copy link
Copy Markdown
Contributor Author

@jainankitk
Copy link
Copy Markdown
Contributor

@asimmahmood1 - Merging from latest main might help with some of the flaky tests

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 2e15536: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for c3190ca: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Copy Markdown
Contributor

@bharath-techie bharath-techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for c3190ca: SUCCESS

* follow up to opensearch-project#18889, which added to NumberFieldMapper
* remaining are Boolean, which I'm not if its worth adding to
* next step is to enable it by default, pending benchmark
* update ScaledFloat testRangeQuery to apply same rounding logic to query as indexing to reduce the flakiness

Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for c2ab72a: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for c2ab72a: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for c2ab72a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@asimmahmood1
Copy link
Copy Markdown
Contributor Author

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for c2ab72a: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants