Add skip_list parameter to Numeric Field Mappers (default false)#18889
Add skip_list parameter to Numeric Field Mappers (default false)#18889prudhvigodithi merged 8 commits intoopensearch-project:mainfrom
Conversation
|
❌ Gradle check result for 2ce6624: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for e03141b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bef4570 to
0a516d9
Compare
- Add skip_list parameter to numeric field mappers (default false) - Add mapping unit tests for skip_list functionality Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
0a516d9 to
05f99db
Compare
|
❌ Gradle check result for 05f99db: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Hello! |
|
❌ Gradle check result for ca81788: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for ca81788: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bharath-techie
left a comment
There was a problem hiding this comment.
LGTM as default is false
|
@bugmakerrrrrr Hoping to get this into 3.2. If its ok with you, we can revisit it to list or other config, which should very low impact since the default value is false (i.e. no-op). |
Signed-off-by: Asim M <asim.seng@gmail.com>
Signed-off-by: Asim M <asim.seng@gmail.com>
…nsearch-project#18889) * Add skip_list parameter to Numeric Field Mappers - Add skip_list parameter to numeric field mappers (default false) - Add mapping unit tests for skip_list functionality Signed-off-by: Asim Mahmood <asim.seng@gmail.com> * Fix test Signed-off-by: Asim Mahmood <asim.seng@gmail.com> * Remove unused code Signed-off-by: Asim Mahmood <asim.seng@gmail.com> --------- Signed-off-by: Asim Mahmood <asim.seng@gmail.com> Signed-off-by: Asim M <asim.seng@gmail.com>
|
Hello! |
* follow up to opensearch-project#18889, which added to NumberFieldMapper * remaining are Boolean, which I'm not if its worth adding to * next step is to enable it by default, pending benchmark Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
Description
skip_listthat will enable indexing of skiplists, if doc_values is also true, otherwise it has no effectRelated Issues
Resolves [#17965]
Replace PR [https://github.com//pull/18066]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.