Skip to content

Support system generated search pipeline.#19128

Merged
owaiskazi19 merged 1 commit intoopensearch-project:mainfrom
bzhangam:systemsearchpipeline
Sep 11, 2025
Merged

Support system generated search pipeline.#19128
owaiskazi19 merged 1 commit intoopensearch-project:mainfrom
bzhangam:systemsearchpipeline

Conversation

@bzhangam
Copy link
Copy Markdown
Contributor

@bzhangam bzhangam commented Aug 22, 2025

Description

Support system generated search pipeline and also support the stats for it.

Also have done a simple microbenchmark On Apple M3 Pro 36 GB.

Create a dummy processor factory which will check if query in the search request is bool query. If it is then create the dummy processor. And below are the average time used to loop through 100 and 1000 dummy factories to evaluate the search request.

Benchmark Mode Cnt Score Error Units
SearchPipelineEvaluationBenchmark.evaluate(100 factories) avgt 5 0.031 ±0.001 us/op
SearchPipelineEvaluationBenchmark.evaluate(1000 factories) avgt 5 0.285 ±0.018 us/op

Even we need to use 1000 factories to evaluate the search request as long as the evaluation logic is a simple if else check it only needs less than 1us which is negligible.

After adding the metrics for evaluation and generation the latency goes much higher but still negligible. less than 0.1 ms for 1000 factories.

Benchmark Mode Cnt Score Error Units
SearchPipelineEvaluationBenchmark.evaluate(100 factories) avgt 5 0.005 ±0.001 ms/op
SearchPipelineEvaluationBenchmark.evaluate(1000 factories) avgt 5 0.051 ±0.001 ms/op

Will raise a separate PR to add example plugin and integ tests for this change.

Related Issues

Resolves #18731

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc labels Aug 22, 2025
@bzhangam bzhangam closed this Aug 22, 2025
@bzhangam bzhangam force-pushed the systemsearchpipeline branch from a795257 to 4b091fc Compare August 22, 2025 20:15
@bzhangam bzhangam reopened this Aug 22, 2025
Signed-off-by: Bo Zhang <bzhangam@amazon.com>
@bzhangam bzhangam reopened this Sep 8, 2025
@bzhangam
Copy link
Copy Markdown
Contributor Author

bzhangam commented Sep 8, 2025

@atris Addressed your comments. Can you take another look?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 8, 2025

❌ Gradle check result for 01c21d5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 8, 2025

✅ Gradle check result for 01c21d5: SUCCESS

@owaiskazi19 owaiskazi19 merged commit c012a51 into opensearch-project:main Sep 11, 2025
85 of 88 checks passed
@owaiskazi19
Copy link
Copy Markdown
Member

@bzhangam please add example plugin and ITs in a new PR

@bzhangam
Copy link
Copy Markdown
Contributor Author

@bzhangam please add example plugin and ITs in a new PR

Sure will raise a PR for it soon.

bzhangam added a commit to bzhangam/OpenSearch that referenced this pull request Sep 18, 2025
Signed-off-by: Bo Zhang <bzhangam@amazon.com>
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
Signed-off-by: Bo Zhang <bzhangam@amazon.com>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
Signed-off-by: Bo Zhang <bzhangam@amazon.com>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
asimmahmood1 pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 23, 2025
pranikum pushed a commit to pranikum/OpenSearch that referenced this pull request Sep 23, 2025
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc v3.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Search Pipeline] Support System Generated Search Pipeline/ Processors

5 participants