Attempt to fix o.o.transport.netty4.OpenSearchLoggingHandlerIT fails w/ stack overflow by hardening test expectation patterns#1900
Merged
nknize merged 1 commit intoopensearch-project:mainfrom Jan 14, 2022
Conversation
…w/ stack overflow by hardening test expectation patterns Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
commented
Jan 13, 2022
| final String writePattern = "^.*\\[length: \\d+" | ||
| + ", request id: \\d+" | ||
| + ", type: request" | ||
| + ", version: .*" |
Contributor
Author
There was a problem hiding this comment.
Making regexes more strict and constrained.
Collaborator
|
Can one of the admins verify this patch? |
nknize
approved these changes
Jan 14, 2022
Contributor
nknize
left a comment
There was a problem hiding this comment.
LGTM. Thanks for digging into this stackOverflow. It's an elusive one and hard to repro.
Contributor
Author
|
Thanks @nknize , I will keep an eye on it, in case it pops up again, really nasty one |
reta
added a commit
to reta/OpenSearch
that referenced
this pull request
Jan 14, 2022
…st failure (opensearch-project#1900) Attempt to fix o.o.transport.netty4.OpenSearchLoggingHandlerIT fails w/ stack overflow by hardening test expectation patterns in regex patterns Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
Attempt to fix
o.o.transport.netty4.OpenSearchLoggingHandlerITfails w/ stack overflow by hardening test expectation patterns. I was not able to reproduce the issue locally but suspects are:Log4j(specific message) and our ownMockLogAppender.LoggingExpectation. At least, if the issue continues to manifest, we should be able to excludeMockLogAppender.LoggingExpectationfrom suspects.Issues Resolved
Possibly closes #1767
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.