Extend profile capabilities to plugins#18656
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18656 +/- ##
============================================
- Coverage 72.86% 72.82% -0.05%
+ Complexity 68571 68541 -30
============================================
Files 5566 5566
Lines 314513 314701 +188
Branches 45636 45653 +17
============================================
+ Hits 229167 229170 +3
- Misses 66789 66999 +210
+ Partials 18557 18532 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cef03ba to
d723702
Compare
|
❌ Gradle check result for d723702: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@neuenfeldttj thank you for pulling it off, a super minor comment but LGTM otherwise, we need to have build green, could you please work on that? @andrross @msfroh if you have some spare cycles to look at it, would be great, thank you. |
Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
Signed-off-by: TJ Neuenfeldt <56700214+neuenfeldttj@users.noreply.github.com>
|
❌ Gradle check result for 10db8a4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: TJ Neuenfeldt <56700214+neuenfeldttj@users.noreply.github.com>
|
❌ Gradle check result for 21d1030: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
|
❌ Gradle check result for 73ac38b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for aa4f55d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
andrross
left a comment
There was a problem hiding this comment.
Just one nitpick, otherwise looks good
Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
|
❌ Gradle check result for f7c4bd0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
reta
left a comment
There was a problem hiding this comment.
Thanks a lot @neuenfeldttj !
* port over plugin extension, double check with knn tests Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * changelog, added tests, changed to contexualpb for context Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * spotless Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * renamed, made extension point a function Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * changelog, default ctors Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * added getter, changed to findProfileBreakdown Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * changelog and abstractpb Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * trigger Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * revert breaking change Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * trigger Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * trigger build Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * search module nit fix Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * spotless Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> --------- Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> Signed-off-by: TJ Neuenfeldt <56700214+neuenfeldttj@users.noreply.github.com>
* port over plugin extension, double check with knn tests Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * changelog, added tests, changed to contexualpb for context Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * spotless Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * renamed, made extension point a function Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * changelog, default ctors Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * added getter, changed to findProfileBreakdown Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * changelog and abstractpb Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * trigger Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * revert breaking change Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * trigger Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * trigger build Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * search module nit fix Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> * spotless Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> --------- Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com> Signed-off-by: TJ Neuenfeldt <56700214+neuenfeldttj@users.noreply.github.com>
Description
This continues extending the profiling with plugins. Now that we have
ProfileMetrics, we can have plugins piggy-back off of the default query profiler and provide a hashmap of metric suppliers. Plugins that provide queries can add profile metrics and profile what they want. They achieve this by getting the top breakdown context (since the default query handles the profile tree creation). Because of the new plugin extension, there will be API changes!Related Issues
Resolves #18460
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.