Remove redundant step from IndexActionIT#testAutoGenerateIdNoDuplicates#18630
Merged
msfroh merged 1 commit intoopensearch-project:mainfrom Jun 27, 2025
Merged
Conversation
testAutoGenerateIdNoDuplicates was modified back in 2014 to search all docs in the index and to search all docs of a given type in the index. When types were removed in OpenSearch 2.0, that second check had the type removed, making it identical to the first check. This change essentially goes back to the pre-2014 version, when the test was just searching all docs in the index once. Also, I modified the test to change index names on every iteration in the hope that it becomes a bit less flaky. Generating a different index on every iteration does not appear to violate the spirit of the test. Signed-off-by: Michael Froh <msfroh@apache.org>
3 tasks
rishabhmaurya
approved these changes
Jun 26, 2025
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18630 +/- ##
============================================
- Coverage 72.83% 72.78% -0.06%
+ Complexity 68450 68390 -60
============================================
Files 5563 5563
Lines 314144 314144
Branches 45544 45544
============================================
- Hits 228810 228639 -171
- Misses 66807 66994 +187
+ Partials 18527 18511 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sandeshkr419
approved these changes
Jun 27, 2025
vishdivs
pushed a commit
to vishdivs/OpenSearch
that referenced
this pull request
Jul 14, 2025
…es (opensearch-project#18630) testAutoGenerateIdNoDuplicates was modified back in 2014 to search all docs in the index and to search all docs of a given type in the index. When types were removed in OpenSearch 2.0, that second check had the type removed, making it identical to the first check. This change essentially goes back to the pre-2014 version, when the test was just searching all docs in the index once. Also, I modified the test to change index names on every iteration in the hope that it becomes a bit less flaky. Generating a different index on every iteration does not appear to violate the spirit of the test. Signed-off-by: Michael Froh <msfroh@apache.org>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Aug 5, 2025
…es (opensearch-project#18630) testAutoGenerateIdNoDuplicates was modified back in 2014 to search all docs in the index and to search all docs of a given type in the index. When types were removed in OpenSearch 2.0, that second check had the type removed, making it identical to the first check. This change essentially goes back to the pre-2014 version, when the test was just searching all docs in the index once. Also, I modified the test to change index names on every iteration in the hope that it becomes a bit less flaky. Generating a different index on every iteration does not appear to violate the spirit of the test. Signed-off-by: Michael Froh <msfroh@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
testAutoGenerateIdNoDuplicates was modified back in 2014 to search all docs in the index and to search all docs of a given type in the index. When types were removed in OpenSearch 2.0, that second check had the type removed, making it identical to the first check.
This change essentially goes back to the pre-2014 version, when the test was just searching all docs in the index once.
Also, I modified the test to change index names on every iteration in the hope that it becomes a bit less flaky. Generating a different index on every iteration does not appear to violate the spirit of the test.
Related Issues
Might help with #16576
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.