Skip to content

Add NodeResourceUsageStats to ClusterInfo#18480

Merged
gbbafna merged 20 commits intoopensearch-project:mainfrom
abhita:newClusterInfo1
Jun 23, 2025
Merged

Add NodeResourceUsageStats to ClusterInfo#18480
gbbafna merged 20 commits intoopensearch-project:mainfrom
abhita:newClusterInfo1

Conversation

@abhita
Copy link
Copy Markdown
Contributor

@abhita abhita commented Jun 10, 2025

Description

Add NodeResourceUsageStats to ClusterInfo to make Node-level usage stats available to all nodes

Related Issues

Resolves #[[Writable Warm] Adding Support For NodeResourceUsageStats in ClusterInfo]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Abhita Lakkabathini <abhital@amazon.com>
@abhita abhita requested a review from a team as a code owner June 10, 2025 04:56
@github-actions github-actions bot added the Meta Meta issue, not directly linked to a PR label Jun 10, 2025
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 12c0e4d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for a1af9eb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for e68568d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@abhita abhita force-pushed the newClusterInfo1 branch from e68568d to a1af9eb Compare June 17, 2025 12:16
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 51.11111% with 22 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (e2deff6) to head (3933318).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...va/org/opensearch/node/NodeResourceUsageStats.java 0.00% 9 Missing ⚠️
...opensearch/cluster/InternalClusterInfoService.java 68.18% 4 Missing and 3 partials ⚠️
.../main/java/org/opensearch/cluster/ClusterInfo.java 61.53% 2 Missing and 3 partials ⚠️
...a/org/opensearch/node/NodesResourceUsageStats.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18480      +/-   ##
============================================
+ Coverage     72.69%   72.75%   +0.05%     
- Complexity    68159    68182      +23     
============================================
  Files          5541     5541              
  Lines        313391   313426      +35     
  Branches      45474    45479       +5     
============================================
+ Hits         227829   228030     +201     
+ Misses        67071    66850     -221     
- Partials      18491    18546      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 28c13e3: SUCCESS

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for ad45f2b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for b9c94b9:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 8f98f76: SUCCESS

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for bce898a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 7f6fa73: SUCCESS

Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

❕ Gradle check result for 3933318: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gbbafna gbbafna merged commit d404f33 into opensearch-project:main Jun 23, 2025
29 of 31 checks passed
@andrross
Copy link
Copy Markdown
Member

andrross commented Jun 25, 2025

@gbbafna @abhita I believe the test failure in the last gradle check run in this PR comment link is caused by this change. That test failure is now impacting other PRs.

I think the root cause is that the onOrAfter checks in this PR need to be V_3_2_0 instead of V_3_1_0 since this change does not exist in version 3.1.

neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
Signed-off-by: Abhita Lakkabathini <abhital@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
Signed-off-by: Abhita Lakkabathini <abhital@amazon.com>
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
Signed-off-by: Abhita Lakkabathini <abhital@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Meta Meta issue, not directly linked to a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Writable Warm] Adding Support For NodeResourceUsageStats in ClusterInfo

5 participants