Skip to content

[rule based autotagging] Add Delete Rule API Logic#18184

Merged
jainankitk merged 15 commits intoopensearch-project:mainfrom
ruai0511:delete-rule-api-pr-v2
May 20, 2025
Merged

[rule based autotagging] Add Delete Rule API Logic#18184
jainankitk merged 15 commits intoopensearch-project:mainfrom
ruai0511:delete-rule-api-pr-v2

Conversation

@Lindsay-00
Copy link
Copy Markdown
Contributor

@Lindsay-00 Lindsay-00 commented May 2, 2025

Description

This PR introduces the Delete Rule API Logic.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Lingxi Chen added 2 commits May 1, 2025 16:48
delete rule feature
e39446a 
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
unit tests
5129a79 
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
@Lindsay-00 Lindsay-00 requested a review from a team as a code owner May 2, 2025 09:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2025

❌ Gradle check result for 5129a79: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

ruai0511
ruai0511 reviewed May 5, 2025
View reviewed changes
Comment thread modules/autotagging-commons/common/src/main/java/org/opensearch/rule/DeleteRuleRequest.java Outdated
Comment thread modules/autotagging-commons/common/src/main/java/org/opensearch/rule/DeleteRuleRequest.java Outdated
Comment thread modules/autotagging-commons/common/src/main/java/org/opensearch/rule/DeleteRuleResponse.java Outdated
Comment thread .../autotagging-commons/src/main/java/org/opensearch/rule/action/TransportDeleteRuleAction.java Outdated
Comment thread modules/autotagging-commons/src/main/java/org/opensearch/rule/rest/RestDeleteRuleAction.java
revised based on comments
c6a1825 
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

❌ Gradle check result for c6a1825: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

revised based on comments
f37990f 
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2025

❌ Gradle check result for f37990f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

ruai0511
ruai0511 approved these changes May 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ruai0511 ruai0511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

revised based on comments
c6d6515 
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
Revert to commit f37990f
1669731 
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2025

❌ Gradle check result for 1669731: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

jainankitk
jainankitk reviewed May 7, 2025
View reviewed changes
Comment thread modules/autotagging-commons/common/src/main/java/org/opensearch/rule/DeleteRuleRequest.java Outdated
Comment thread modules/autotagging-commons/common/src/main/java/org/opensearch/rule/DeleteRuleRequest.java
Comment thread ...mons/common/src/main/java/org/opensearch/rule/service/IndexStoredRulePersistenceService.java
Comment thread .../autotagging-commons/src/main/java/org/opensearch/rule/action/TransportDeleteRuleAction.java
@Lindsay-00
Copy link
Copy Markdown
Contributor Author

Lindsay-00 commented May 7, 2025

@jainankitk For Feature Type we're keeping it to get the RulePersistenceService from the Registry class

fixing comments
5e38cb0 
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2025

❌ Gradle check result for 5e38cb0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Copy Markdown
Contributor

jainankitk commented May 8, 2025

@Lindsay-00 - Can you resolve the failing precommit and other checks?

fixing precommit error
0d33419 
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2025

❌ Gradle check result for 0d33419: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Copy Markdown
Contributor

jainankitk commented May 8, 2025

@Lindsay-00 - Precommit is still failing. Maybe you can try running it locally to verify? Also, can you add changelog entry?

Lingxi Chen added 2 commits May 12, 2025 13:47
fixed precommit error in IndexStoredRulePersistenceServiceTests
170d776 
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
changed changelog
2120016 
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2025

❌ Gradle check result for 2120016: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Copy Markdown
Contributor

jainankitk commented May 13, 2025

@Lindsay-00 - Failures look related, can you check:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/57992/testReport/) (2 failures / +2)

    [org.opensearch.rule.service.IndexStoredRulePersistenceServiceTests.testDeleteRule_notFound](https://build.ci.opensearch.org/job/gradle-check/57992/testReport/junit/org.opensearch.rule.service/IndexStoredRulePersistenceServiceTests/testDeleteRule_notFound/)
    [org.opensearch.rule.service.IndexStoredRulePersistenceServiceTests.testDeleteRule_successful](https://build.ci.opensearch.org/job/gradle-check/57992/testReport/junit/org.opensearch.rule.service/IndexStoredRulePersistenceServiceTests/testDeleteRule_successful/)

fixing jenkins tests
f1f0783 
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2025

❌ Gradle check result for f1f0783: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Lindsay-00
Copy link
Copy Markdown
Contributor Author

Lindsay-00 commented May 13, 2025

@Lindsay-00 - Failures look related, can you check:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/57992/testReport/) (2 failures / +2)

    [org.opensearch.rule.service.IndexStoredRulePersistenceServiceTests.testDeleteRule_notFound](https://build.ci.opensearch.org/job/gradle-check/57992/testReport/junit/org.opensearch.rule.service/IndexStoredRulePersistenceServiceTests/testDeleteRule_notFound/)
    [org.opensearch.rule.service.IndexStoredRulePersistenceServiceTests.testDeleteRule_successful](https://build.ci.opensearch.org/job/gradle-check/57992/testReport/junit/org.opensearch.rule.service/IndexStoredRulePersistenceServiceTests/testDeleteRule_successful/)

Thanks for pointing it out! Just fixed them.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2025

❌ Gradle check result for f1f0783: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2025

❌ Gradle check result for 7f90f40: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2025

❌ Gradle check result for 7f90f40: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request May 14, 2025
Open
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2025

❌ Gradle check result for 7f90f40: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2025

❌ Gradle check result for 7f90f40: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Copy Markdown
Contributor

jainankitk commented May 16, 2025

@Lindsay-00 - Can you check the build log for issues? - https://build.ci.opensearch.org/job/gradle-check/58062/console. cc: @kaushalmahi12

Lingxi Chen added 2 commits May 19, 2025 11:11
fix gradle check error
6f23de0 
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
Merge branch 'delete-rule-api-pr-v2' of https://github.com/ruai0511/O…
1ea4330 
…penSearch into delete-rule-api-pr-v2
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2025

❌ Gradle check result for 1ea4330: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

fix assertion error
cddf074 
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2025

❕ Gradle check result for cddf074: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72.52%. Comparing base (998ae73) to head (cddf074).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...org/opensearch/rule/rest/RestDeleteRuleAction.java 30.00% 7 Missing ⚠️
...ule/service/IndexStoredRulePersistenceService.java 60.00% 3 Missing and 3 partials ⚠️
...in/java/org/opensearch/rule/DeleteRuleRequest.java 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #18184      +/-   ##
============================================
+ Coverage     72.48%   72.52%   +0.03%     
- Complexity    67357    67385      +28     
============================================
  Files          5488     5492       +4     
  Lines        311023   311076      +53     
  Branches      45217    45218       +1     
============================================
+ Hits         225444   225606     +162     
+ Misses        67282    67063     -219     
- Partials      18297    18407     +110

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced May 20, 2025
Open
Open
@jainankitk jainankitk merged commit 54af445 into opensearch-project:main May 20, 2025
30 checks passed
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Jun 1, 2025
@Lindsay-00 @tandonks
[rule based autotagging] Add Delete Rule API Logic (opensearch-projec…
b5d5992 
…t#18184)

Signed-off-by: Lingxi Chen <lingxich@amazon.com>
Co-authored-by: Lingxi Chen <lingxich@amazon.com>
@BrewTestBot BrewTestBot mentioned this pull request Jun 24, 2025
Merged
neuenfeldttj added a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
@Lindsay-00 @neuenfeldttj
[rule based autotagging] Add Delete Rule API Logic (opensearch-projec…
455d845 
…t#18184)

Signed-off-by: Lingxi Chen <lingxich@amazon.com>
Co-authored-by: Lingxi Chen <lingxich@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
@Lindsay-00 @neuenfeldttj
[rule based autotagging] Add Delete Rule API Logic (opensearch-projec…
fa0ec72 
…t#18184)

Signed-off-by: Lingxi Chen <lingxich@amazon.com>
Co-authored-by: Lingxi Chen <lingxich@amazon.com>
@ruai0511 ruai0511 deleted the delete-rule-api-pr-v2 branch July 9, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jainankitk jainankitk jainankitk approved these changes

+2 more reviewers

@kaushalmahi12 kaushalmahi12 kaushalmahi12 approved these changes

@ruai0511 ruai0511 ruai0511 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Lindsay-00 @jainankitk @kaushalmahi12 @ruai0511