Skip to content

[Star tree] Remove star tree feature flag and add index setting to configure star tree search on index basis#18070

Merged
rishabhmaurya merged 8 commits intoopensearch-project:mainfrom
bharath-techie:star-ff
Jun 10, 2025
Merged

[Star tree] Remove star tree feature flag and add index setting to configure star tree search on index basis#18070
rishabhmaurya merged 8 commits intoopensearch-project:mainfrom
bharath-techie:star-ff

Conversation

@bharath-techie
Copy link
Copy Markdown
Contributor

@bharath-techie bharath-techie commented Apr 24, 2025 •
edited
Loading

This change removes feature flag for star tree index and queries.

Description

  1. In both search (server/src/main/java/org/opensearch/search/DefaultSearchContext.java) and indexing validations (server/src/main/java/org/opensearch/index/compositeindex/datacube/startree/StarTreeValidator.java) , we first check for explicit index setting and if present, we use the value otherwise we fallback to cluster setting.
  2. In search with the help of index setting, users will be able to turn off star tree search at index level if they want to test out / see issues etc.
  3. By default both the cluster setting "indices.composite_index.star_tree.enabled" and index setting "index.search.star_tree_index.enabled" are "true"

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 24, 2025

❌ Gradle check result for 135be39: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 28, 2025

❌ Gradle check result for f7b7caf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 28, 2025

❌ Gradle check result for a97f1eb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 28, 2025

❌ Gradle check result for 82001bc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 28, 2025

❌ Gradle check result for 8bcc71f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 28, 2025

❌ Gradle check result for 5eb7ac3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bharath-techie
Adding more tests for feature flag
fe11e40 
Signed-off-by: bharath-techie <bharath78910@gmail.com>
@bharath-techie
Adding Changelog
97ecc01 
Signed-off-by: bharath-techie <bharath78910@gmail.com>
@bharath-techie
addressing review comment
f6c1cce 
Signed-off-by: bharath-techie <bharath78910@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 10, 2025

❌ Gradle check result for 5a90f9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 10, 2025

❌ Gradle check result for f6c1cce: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 10, 2025

❕ Gradle check result for 40d503d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@rishabhmaurya rishabhmaurya merged commit bef982a into opensearch-project:main Jun 10, 2025
30 checks passed
@sandeshkr419 sandeshkr419 mentioned this pull request Jun 10, 2025
Merged
3 tasks
This was referenced Jun 10, 2025
Open
Open
q-andy pushed a commit to q-andy/OpenSearch that referenced this pull request Jun 11, 2025
@bharath-techie @q-andy
[Star tree] Remove star tree feature flag and add index setting to co…
cf2051a 
…nfigure star tree search on index basis (opensearch-project#18070)

* Removing star tree indexing and queries added till 2.19 out of experimental

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Removing star tree feature flag

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Adding more tests for feature flag

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Adding Changelog

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* addressing review comment

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* resolving conflicts

Signed-off-by: bharath-techie <bharath78910@gmail.com>

---------

Signed-off-by: bharath-techie <bharath78910@gmail.com>
@sandeshkr419 sandeshkr419 mentioned this pull request Jun 11, 2025
Open
abhita pushed a commit to abhita/OpenSearch that referenced this pull request Jun 17, 2025
@bharath-techie @abhita
[Star tree] Remove star tree feature flag and add index setting to co…
d9922f0 
…nfigure star tree search on index basis (opensearch-project#18070)

* Removing star tree indexing and queries added till 2.19 out of experimental

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Removing star tree feature flag

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Adding more tests for feature flag

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Adding Changelog

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* addressing review comment

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* resolving conflicts

Signed-off-by: bharath-techie <bharath78910@gmail.com>

---------

Signed-off-by: bharath-techie <bharath78910@gmail.com>
@sandeshkr419 sandeshkr419 mentioned this pull request Jun 23, 2025
Merged
1 task
@BrewTestBot BrewTestBot mentioned this pull request Jun 24, 2025
Merged
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
@bharath-techie
[Star tree] Remove star tree feature flag and add index setting to co…
11ed2b4 
…nfigure star tree search on index basis (opensearch-project#18070)

* Removing star tree indexing and queries added till 2.19 out of experimental

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Removing star tree feature flag

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Adding more tests for feature flag

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Adding Changelog

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* addressing review comment

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* resolving conflicts

Signed-off-by: bharath-techie <bharath78910@gmail.com>

---------

Signed-off-by: bharath-techie <bharath78910@gmail.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
@bharath-techie @neuenfeldttj
[Star tree] Remove star tree feature flag and add index setting to co…
b9a2ab9 
…nfigure star tree search on index basis (opensearch-project#18070)

* Removing star tree indexing and queries added till 2.19 out of experimental

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Removing star tree feature flag

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Adding more tests for feature flag

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Adding Changelog

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* addressing review comment

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* resolving conflicts

Signed-off-by: bharath-techie <bharath78910@gmail.com>

---------

Signed-off-by: bharath-techie <bharath78910@gmail.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jul 9, 2025
Open
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
@bharath-techie @tandonks
[Star tree] Remove star tree feature flag and add index setting to co…
fa67a07 
…nfigure star tree search on index basis (opensearch-project#18070)

* Removing star tree indexing and queries added till 2.19 out of experimental

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Removing star tree feature flag

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Adding more tests for feature flag

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* Adding Changelog

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* addressing review comment

Signed-off-by: bharath-techie <bharath78910@gmail.com>

* resolving conflicts

Signed-off-by: bharath-techie <bharath78910@gmail.com>

---------

Signed-off-by: bharath-techie <bharath78910@gmail.com>
@tkykenmt tkykenmt mentioned this pull request Jan 10, 2026
Merged
@ThyTran1402 ThyTran1402 mentioned this pull request Mar 19, 2026
Open
3 tasks
qianchongyang pushed a commit to qianchongyang/OpenSearch that referenced this pull request Mar 20, 2026
refactor: replace @experimentalapi with @publicapi in star-tree code
ba33933 
Replaced @experimentalapi annotations with @publicapi(since = "3.6.0")
in all star-tree related code files (34 files).

Changes:
- Removed @experimentalapi annotations
- Added @publicapi(since = "3.6.0") as replacement

Related to: opensearch-project#18070, resolves opensearch-project#18499

Fixes opensearch-project#20925
@qianchongyang qianchongyang mentioned this pull request Mar 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwetathareja shwetathareja shwetathareja approved these changes

@sandeshkr419 sandeshkr419 sandeshkr419 approved these changes

@mgodwan mgodwan mgodwan approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@bugmakerrrrrr bugmakerrrrrr Awaiting requested review from bugmakerrrrrr

@jainankitk jainankitk Awaiting requested review from jainankitk

@linuxpi linuxpi Awaiting requested review from linuxpi

Assignees

No one assigned

Labels

v3.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bharath-techie @sandeshkr419 @shwetathareja @mgodwan @rishabhmaurya