Add FIPS build tooling#17907
Conversation
|
❌ Gradle check result for 0bd8f13: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
0bd8f13 to
e128e8a
Compare
|
❌ Gradle check result for e128e8a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
cabd094 to
3aae4ce
Compare
|
❌ Gradle check result for 3aae4ce: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3aae4ce to
abfb83a
Compare
|
❌ Gradle check result for abfb83a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
abfb83a to
11cf500
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17907 +/- ##
============================================
- Coverage 72.74% 72.70% -0.04%
+ Complexity 67767 67722 -45
============================================
Files 5497 5499 +2
Lines 311815 311864 +49
Branches 45261 45271 +10
============================================
- Hits 226822 226733 -89
- Misses 66504 66618 +114
- Partials 18489 18513 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
11cf500 to
81729ad
Compare
|
❌ Gradle check result for 81729ad: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
81729ad to
c3cd834
Compare
|
❌ Gradle check result for c3cd834: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
c3cd834 to
df45869
Compare
|
To include FIPS test coverage in the build, an additional test suite is required. Thankfully, @cwperks has already provided a skeleton for it - which we’ll extend and integrate shortly. |
buildSrc/src/main/java/org/opensearch/gradle/OpenSearchTestBasePlugin.java
Show resolved
Hide resolved
client/rest/src/test/java/org/opensearch/client/RestClientBuilderIntegTests.java
Outdated
Show resolved
Hide resolved
...ools/plugin-cli/src/test/java/org/opensearch/tools/cli/plugin/InstallPluginCommandTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/bootstrap/SecurityProviderManager.java
Outdated
Show resolved
Hide resolved
|
Hi @beanuwave , |
Hi @prakashsatpathy you are absolutely right - the changes from this PR need to be merged into #14912 . Although it's stale and won't be reviewed anymore, we’re keeping it open as a backreference and to serve as a code diff for upcoming PRs. |
…ls/cli/plugin/InstallPluginCommandTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com>
…Manager.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com>
…SSWORD when running docker tests. Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> # Conflicts: # server/src/main/java/org/opensearch/common/Randomness.java
3a74481 to
36da087
Compare
|
❌ Gradle check result for 36da087: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
36da087 to
9452133
Compare
|
❌ Gradle check result for 9452133: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…er#removeNonCompliantFipsProviders Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
9452133 to
278f287
Compare
* Add FIPS build-tooling Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> # Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md * Update distribution/tools/plugin-cli/src/test/java/org/opensearch/tools/cli/plugin/InstallPluginCommandTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> * Update server/src/main/java/org/opensearch/bootstrap/SecurityProviderManager.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> * add additional '-Ptests.fips.enabled=true' parameter; set KEYSTORE_PASSWORD when running docker tests. Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * prevent bc deps propagation outside their modules Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * change TestUtilsTests to test for cryptographic equality Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * use 'fipsOnly' for all BC declarations Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * fix: do not allow other values than 'FIPS-140-3' for 'crypto.standard' Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * exclude BC from client & server compile scope Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * Refactor BootstrapForTesting & Randomness Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * revert Randomness.java Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> # Conflicts: # server/src/main/java/org/opensearch/common/Randomness.java * rename SecurityProviderManager#excludeSunJCE to SecurityProviderManager#removeNonCompliantFipsProviders Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> --------- Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Igonin <iigonin@sternad.de> Co-authored-by: Andriy Redko <drreta@gmail.com> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
* Add FIPS build-tooling Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> # Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md * Update distribution/tools/plugin-cli/src/test/java/org/opensearch/tools/cli/plugin/InstallPluginCommandTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> * Update server/src/main/java/org/opensearch/bootstrap/SecurityProviderManager.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> * add additional '-Ptests.fips.enabled=true' parameter; set KEYSTORE_PASSWORD when running docker tests. Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * prevent bc deps propagation outside their modules Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * change TestUtilsTests to test for cryptographic equality Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * use 'fipsOnly' for all BC declarations Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * fix: do not allow other values than 'FIPS-140-3' for 'crypto.standard' Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * exclude BC from client & server compile scope Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * Refactor BootstrapForTesting & Randomness Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * revert Randomness.java Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> # Conflicts: # server/src/main/java/org/opensearch/common/Randomness.java * rename SecurityProviderManager#excludeSunJCE to SecurityProviderManager#removeNonCompliantFipsProviders Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> --------- Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Igonin <iigonin@sternad.de> Co-authored-by: Andriy Redko <drreta@gmail.com> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
* Add FIPS build-tooling Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> # Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md * Update distribution/tools/plugin-cli/src/test/java/org/opensearch/tools/cli/plugin/InstallPluginCommandTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> * Update server/src/main/java/org/opensearch/bootstrap/SecurityProviderManager.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> * add additional '-Ptests.fips.enabled=true' parameter; set KEYSTORE_PASSWORD when running docker tests. Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * prevent bc deps propagation outside their modules Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * change TestUtilsTests to test for cryptographic equality Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * use 'fipsOnly' for all BC declarations Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * fix: do not allow other values than 'FIPS-140-3' for 'crypto.standard' Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * exclude BC from client & server compile scope Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * Refactor BootstrapForTesting & Randomness Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * revert Randomness.java Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> # Conflicts: # server/src/main/java/org/opensearch/common/Randomness.java * rename SecurityProviderManager#excludeSunJCE to SecurityProviderManager#removeNonCompliantFipsProviders Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> --------- Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Igonin <iigonin@sternad.de> Co-authored-by: Andriy Redko <drreta@gmail.com> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
* Add FIPS build-tooling Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> # Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md * Update distribution/tools/plugin-cli/src/test/java/org/opensearch/tools/cli/plugin/InstallPluginCommandTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> * Update server/src/main/java/org/opensearch/bootstrap/SecurityProviderManager.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> * add additional '-Ptests.fips.enabled=true' parameter; set KEYSTORE_PASSWORD when running docker tests. Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * prevent bc deps propagation outside their modules Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * change TestUtilsTests to test for cryptographic equality Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * use 'fipsOnly' for all BC declarations Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * fix: do not allow other values than 'FIPS-140-3' for 'crypto.standard' Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * exclude BC from client & server compile scope Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * Refactor BootstrapForTesting & Randomness Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * revert Randomness.java Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> # Conflicts: # server/src/main/java/org/opensearch/common/Randomness.java * rename SecurityProviderManager#excludeSunJCE to SecurityProviderManager#removeNonCompliantFipsProviders Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> --------- Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Igonin <iigonin@sternad.de> Co-authored-by: Andriy Redko <drreta@gmail.com> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
* Add FIPS build-tooling Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> # Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md * Update distribution/tools/plugin-cli/src/test/java/org/opensearch/tools/cli/plugin/InstallPluginCommandTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> * Update server/src/main/java/org/opensearch/bootstrap/SecurityProviderManager.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> * add additional '-Ptests.fips.enabled=true' parameter; set KEYSTORE_PASSWORD when running docker tests. Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * prevent bc deps propagation outside their modules Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * change TestUtilsTests to test for cryptographic equality Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * use 'fipsOnly' for all BC declarations Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * fix: do not allow other values than 'FIPS-140-3' for 'crypto.standard' Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * exclude BC from client & server compile scope Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * Refactor BootstrapForTesting & Randomness Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * revert Randomness.java Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> # Conflicts: # server/src/main/java/org/opensearch/common/Randomness.java * rename SecurityProviderManager#excludeSunJCE to SecurityProviderManager#removeNonCompliantFipsProviders Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> --------- Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Igonin <iigonin@sternad.de> Co-authored-by: Andriy Redko <drreta@gmail.com> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
* Add FIPS build-tooling Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> # Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md * Update distribution/tools/plugin-cli/src/test/java/org/opensearch/tools/cli/plugin/InstallPluginCommandTests.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> * Update server/src/main/java/org/opensearch/bootstrap/SecurityProviderManager.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> * add additional '-Ptests.fips.enabled=true' parameter; set KEYSTORE_PASSWORD when running docker tests. Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * prevent bc deps propagation outside their modules Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * change TestUtilsTests to test for cryptographic equality Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * use 'fipsOnly' for all BC declarations Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * fix: do not allow other values than 'FIPS-140-3' for 'crypto.standard' Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * exclude BC from client & server compile scope Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * Refactor BootstrapForTesting & Randomness Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> * revert Randomness.java Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> # Conflicts: # server/src/main/java/org/opensearch/common/Randomness.java * rename SecurityProviderManager#excludeSunJCE to SecurityProviderManager#removeNonCompliantFipsProviders Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de> --------- Signed-off-by: Iwan Igonin <83668556+beanuwave@users.noreply.github.com> Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Igonin <iigonin@sternad.de> Co-authored-by: Andriy Redko <drreta@gmail.com> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
Description
Provides the additional build tooling to test & build OS in FIPS JVM with
-Pcrypto.standard=FIPS-140-3or the (deprecated)-Ptests.fips.enabled=trueparameter. Code changes required to run successfully in FIPS mode are not included in this commit, they will be addressed in separate upcoming PRs.Note:
The codecov report may appear inaccurate. Tests for the new
Randomnesslogic exist but are only executed when the build is run with the new FIPS parameters enabled.Related Issues
RFC
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.