Remove Reader Writer Split experimental feature flag#17880
Merged
mch2 merged 13 commits intoopensearch-project:mainfrom Apr 15, 2025
Merged
Remove Reader Writer Split experimental feature flag#17880mch2 merged 13 commits intoopensearch-project:mainfrom
mch2 merged 13 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Contributor
|
❌ Gradle check result for 202f30c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Contributor
|
❌ Gradle check result for 9e2b726: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Apr 14, 2025
Contributor
|
❌ Gradle check result for 25cf1ff: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
vinaykpud
commented
Apr 14, 2025
Contributor
|
❌ Gradle check result for 4481794: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for 4481794: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Apr 15, 2025
This reverts commit 7aa103a. Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
This reverts commit 4481794. Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17880 +/- ##
============================================
- Coverage 72.52% 72.47% -0.05%
+ Complexity 67031 67005 -26
============================================
Files 5470 5470
Lines 309707 309697 -10
Branches 45052 45045 -7
============================================
- Hits 224617 224459 -158
- Misses 66774 66917 +143
- Partials 18316 18321 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mch2
reviewed
Apr 15, 2025
mch2
approved these changes
Apr 15, 2025
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
…ect#17880) * Remove Reader Writer Split experimental feature flag Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Fixed failing tests Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Fixed failing unit tests Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Added back setting updater in Search only Operation routing Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Fixed SpotlessApply Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Fixed the way roles added while creating node for testing Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Revert "Fixed failing unit tests" This reverts commit 7aa103a. Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Revert "Fixed the way roles added while creating node for testing" This reverts commit 4481794. Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Added SEARCH_ROLE to rolesToMap Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> --------- Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
…ect#17880) * Remove Reader Writer Split experimental feature flag Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Fixed failing tests Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Fixed failing unit tests Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Added back setting updater in Search only Operation routing Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Fixed SpotlessApply Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Fixed the way roles added while creating node for testing Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Revert "Fixed failing unit tests" This reverts commit 7aa103a. Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Revert "Fixed the way roles added while creating node for testing" This reverts commit 4481794. Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Added SEARCH_ROLE to rolesToMap Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> --------- Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed RW Split experimental feature flag
Related Issues
Related #15306
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.