Adjust the getAutoExpandReplicaChanges logic to honor search_only mode.#17865
Merged
mch2 merged 5 commits intoopensearch-project:mainfrom Apr 9, 2025
Merged
Adjust the getAutoExpandReplicaChanges logic to honor search_only mode.#17865mch2 merged 5 commits intoopensearch-project:mainfrom
getAutoExpandReplicaChanges logic to honor search_only mode.#17865mch2 merged 5 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
getAutoExpandReplicaChanges logic to honor search_only mode.getAutoExpandReplicaChanges logic to honor search_only mode.
vinaykpud
reviewed
Apr 9, 2025
server/src/main/java/org/opensearch/cluster/metadata/AutoExpandReplicas.java
Outdated
Show resolved
Hide resolved
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17865 +/- ##
============================================
- Coverage 72.46% 72.37% -0.09%
+ Complexity 66502 66443 -59
============================================
Files 5408 5408
Lines 308080 308187 +107
Branches 44720 44747 +27
============================================
- Hits 223239 223064 -175
- Misses 66536 66860 +324
+ Partials 18305 18263 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
vinaykpud
reviewed
Apr 9, 2025
server/src/test/java/org/opensearch/cluster/metadata/AutoExpandReplicasTests.java
Show resolved
Hide resolved
mch2
reviewed
Apr 9, 2025
server/src/main/java/org/opensearch/cluster/metadata/AutoExpandReplicas.java
Outdated
Show resolved
Hide resolved
Contributor
|
❕ Gradle check result for 2cfaf3f: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Contributor
|
❌ Gradle check result for 0d998f9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Contributor
mch2
approved these changes
Apr 9, 2025
This was referenced Apr 14, 2025
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Apr 15, 2025
… mode. (opensearch-project#17865) * Adjust auto expand replica logic Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Add code comments Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Add IT test Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix spotless Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix spotless Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
… mode. (opensearch-project#17865) * Adjust auto expand replica logic Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Add code comments Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Add IT test Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix spotless Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix spotless Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
… mode. (opensearch-project#17865) * Adjust auto expand replica logic Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Add code comments Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Add IT test Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix spotless Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix spotless Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjust the
getAutoExpandReplicaChangeslogic to honor search_only mode.Related Issues
search_onlymode whenauto_expand_replicasis set #17864Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.