Rename search_only_replica settings to search_replica#17857
Rename search_only_replica settings to search_replica#17857andrross merged 4 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
|
❌ Gradle check result for 747ac76: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 0d22144: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 0d22144: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
|
❌ Gradle check result for d7b0f44: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@sandeshkr419 Have seen this one pop up a couple of times as flaky - https://build.ci.opensearch.org/job/gradle-check/55966/testReport/junit/org.opensearch.search.aggregations.startree/RangeAggregatorTests/testRangeAggregation / Could you please take a look? |
|
❌ Gradle check result for d7b0f44: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17857 +/- ##
============================================
- Coverage 72.44% 72.38% -0.07%
+ Complexity 66483 66454 -29
============================================
Files 5409 5409
Lines 308282 308282
Branches 44759 44759
============================================
- Hits 223344 223153 -191
- Misses 66608 66813 +205
+ Partials 18330 18316 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ject#17857) * Rename search_only_replica settings to search_replica Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Fix missed test cases expecting search_only exception messageA Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Fix tests not using setting constant Signed-off-by: Marc Handalian <marc.handalian@gmail.com> --------- Signed-off-by: Marc Handalian <marc.handalian@gmail.com> Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
…ject#17857) * Rename search_only_replica settings to search_replica Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Fix missed test cases expecting search_only exception messageA Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Fix tests not using setting constant Signed-off-by: Marc Handalian <marc.handalian@gmail.com> --------- Signed-off-by: Marc Handalian <marc.handalian@gmail.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
…ject#17857) * Rename search_only_replica settings to search_replica Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Fix missed test cases expecting search_only exception messageA Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Fix tests not using setting constant Signed-off-by: Marc Handalian <marc.handalian@gmail.com> --------- Signed-off-by: Marc Handalian <marc.handalian@gmail.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Description
Rename search_only_replica settings to search_replica
Related Issues
Resolves ##17845
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.