[segment replication] Avoid skewed segment replication lag metric#17831
Conversation
|
❌ Gradle check result for bf0f8c8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>
bf0f8c8 to
2e4c3b6
Compare
|
❕ Gradle check result for 2e4c3b6: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17831 +/- ##
============================================
- Coverage 72.44% 72.40% -0.05%
+ Complexity 66483 66396 -87
============================================
Files 5409 5409
Lines 308282 308283 +1
Branches 44759 44760 +1
============================================
- Hits 223344 223198 -146
- Misses 66608 66767 +159
+ Partials 18330 18318 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
❌ Gradle check result for d97b873: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
d97b873 to
d2260c3
Compare
|
❌ Gradle check result for d2260c3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for d2260c3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
thanks for the change @guojialiang92, would you please push a rebase and we can get this merged. |
d2260c3 to
77167a7
Compare
|
❌ Gradle check result for 77167a7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
77167a7 to
d262dc3
Compare
Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>
d262dc3 to
b382f4e
Compare
|
Thanks, @mch2 |
|
❌ Gradle check result for aa0fa4b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
aa0fa4b to
7d786a8
Compare
…ensearch-project#17831) * avoid skewed sr lag metric Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> * add CHANGELOG Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> * add test Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> --------- Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
…ensearch-project#17831) * avoid skewed sr lag metric Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> * add CHANGELOG Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> * add test Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> --------- Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
…ensearch-project#17831) * avoid skewed sr lag metric Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> * add CHANGELOG Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> * add test Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> --------- Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Description
This PR solves the problem raised by issue 10764.
In the comments of the issue, I added the detailed process of reproducing the problem.
Related Issues
Resolves #[10764]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.