Add a builder to ingestion source#17814
Merged
mch2 merged 1 commit intoopensearch-project:mainfrom Apr 8, 2025
Merged
Conversation
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Contributor
|
❌ Gradle check result for 3dd7845: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❕ Gradle check result for 3dd7845: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17814 +/- ##
============================================
+ Coverage 72.39% 72.41% +0.02%
- Complexity 66066 66299 +233
============================================
Files 5358 5384 +26
Lines 306500 307164 +664
Branches 44409 44555 +146
============================================
+ Hits 221888 222441 +553
- Misses 66474 66575 +101
- Partials 18138 18148 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 14, 2025
Open
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
Signed-off-by: Yupeng Fu <yupeng@uber.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
Signed-off-by: Yupeng Fu <yupeng@uber.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As
IngestionSourcetakes more arguments, it's better to change the constructor to a builder patternBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.