[segment replication] Add cluster setting for retry timeout of publish checkpoint tx action by guojialiang92 · Pull Request #17749 · opensearch-project/OpenSearch

guojialiang92 · 2025-04-01T09:21:51Z

Description

Added a test. In the current situation, if the primary shard publish checkpoint fails, it will cause the replica shard and the primary shard to fail to synchronize.
TransportReplicationAction support specifying retryTimeout.
PublishCheckpointAction use the never give up retry strategy.

Related Issues

Resolves 17595

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2025-04-01T10:02:51Z

❌ Gradle check result for 1edc0ca: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…eckpointAction use the never give up strategy. Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>

github-actions · 2025-04-01T12:11:42Z

✅ Gradle check result for e49aa81: SUCCESS

ashking94

lgtm

github-actions · 2025-04-14T16:08:27Z

❌ Gradle check result for b744f4b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>

github-actions · 2025-04-14T17:07:11Z

❌ Gradle check result for 68a5e9d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…Action_use_never_give_up_retry_strategy # Conflicts: # CHANGELOG.md

github-actions · 2025-04-15T03:31:18Z

❌ Gradle check result for 3eb976e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

ashking94 · 2025-04-15T04:55:49Z

❌ Gradle check result for 3eb976e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Restarted the pr build.

github-actions · 2025-04-15T05:45:07Z

❌ Gradle check result for 3eb976e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…Action_use_never_give_up_retry_strategy

github-actions · 2025-04-15T06:58:24Z

❌ Gradle check result for a3a23a7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>

github-actions · 2025-04-15T07:59:08Z

✅ Gradle check result for e7b926a: SUCCESS

…h checkpoint tx action (opensearch-project#17749) * TransportReplicationAction support specifying retryTimeout, PublishCheckpointAction use the never give up strategy. Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> * support PublishCheckpointAction PUBLISH_CHECK_POINT_RETRY_TIMEOUT to override the default retry timeout Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> * add TransportReplicationAction.getRetryTimeoutSetting Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> * add entry to CHANGELOG.md Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> * rewrite the PR title Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> * modify changelog entry Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> * add comments Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> * update Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> --------- Signed-off-by: guojialiang <guojialiang.2012@bytedance.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>

github-actions bot added bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep labels Apr 1, 2025

TransportReplicationAction support specifying retryTimeout, PublishCh…

e49aa81

…eckpointAction use the never give up strategy. Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>

guojialiang92 force-pushed the dev/PublishCheckpointAction_use_never_give_up_retry_strategy branch from 1edc0ca to e49aa81 Compare April 1, 2025 11:09

ashking94 approved these changes Apr 14, 2025

View reviewed changes

add comments

68a5e9d

Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>

guojialiang92 force-pushed the dev/PublishCheckpointAction_use_never_give_up_retry_strategy branch from b744f4b to 68a5e9d Compare April 14, 2025 16:16

Merge remote-tracking branch 'origin/main' into dev/PublishCheckpoint…

3eb976e

…Action_use_never_give_up_retry_strategy # Conflicts: # CHANGELOG.md

Merge remote-tracking branch 'origin/main' into dev/PublishCheckpoint…

a3a23a7

…Action_use_never_give_up_retry_strategy

update

e7b926a

Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>

ashking94 approved these changes Apr 15, 2025

View reviewed changes

ashking94 merged commit c44d230 into opensearch-project:main Apr 15, 2025
31 checks passed

opensearch-ci-bot mentioned this pull request Apr 15, 2025

[AUTOCUT] Gradle Check Flaky Test Report for IndexActionIT #16576

Open

BrewTestBot mentioned this pull request May 6, 2025

opensearch 3.0.0 Homebrew/homebrew-core#222665

Merged

opensearch-ci-bot mentioned this pull request May 23, 2025

[AUTOCUT] Gradle Check Flaky Test Report for IndexingIT #14302

Open

opensearch-ci-bot mentioned this pull request Apr 1, 2025

[AUTOCUT] Gradle Check Flaky Test Report for DeleteByQueryBasicTests #15820

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[segment replication] Add cluster setting for retry timeout of publish checkpoint tx action#17749

[segment replication] Add cluster setting for retry timeout of publish checkpoint tx action#17749
ashking94 merged 12 commits intoopensearch-project:mainfrom
guojialiang92:dev/PublishCheckpointAction_use_never_give_up_retry_strategy

guojialiang92 commented Apr 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

ashking94 left a comment

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

ashking94 commented Apr 15, 2025

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

guojialiang92 commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

ashking94 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

ashking94 commented Apr 15, 2025

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

guojialiang92 commented Apr 1, 2025 •

edited

Loading