[rule based autotagging] add attribute value store#17342
Merged
jainankitk merged 8 commits intoopensearch-project:mainfrom Feb 24, 2025
Merged
[rule based autotagging] add attribute value store#17342jainankitk merged 8 commits intoopensearch-project:mainfrom
jainankitk merged 8 commits intoopensearch-project:mainfrom
Conversation
Contributor
|
❌ Gradle check result for f575fbd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
sgup432
reviewed
Feb 12, 2025
...oad-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/AttributeValueStore.java
Outdated
Show resolved
Hide resolved
...oad-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/AttributeValueStore.java
Outdated
Show resolved
Hide resolved
...workload-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/TrieBasedStore.java
Outdated
Show resolved
Hide resolved
...workload-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/TrieBasedStore.java
Outdated
Show resolved
Hide resolved
...workload-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/TrieBasedStore.java
Show resolved
Hide resolved
jainankitk
reviewed
Feb 13, 2025
...oad-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/AttributeValueStore.java
Outdated
Show resolved
Hide resolved
...oad-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/AttributeValueStore.java
Outdated
Show resolved
Hide resolved
...workload-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/TrieBasedStore.java
Outdated
Show resolved
Hide resolved
...workload-management/src/main/java/org/opensearch/plugin/wlm/rule/storage/TrieBasedStore.java
Outdated
Show resolved
Hide resolved
Contributor
|
❌ Gradle check result for 24c4ea6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for acdb27c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3 tasks
Contributor
Author
The build seems to be failing because it is creating a 2.19.1 tar but expecting 2.19.0. Will resync with the mainline first to see if it works |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
4fd6e66 to
e944e6a
Compare
Contributor
|
❌ Gradle check result for e944e6a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e944e6a to
55e613d
Compare
Contributor
|
❕ Gradle check result for 55e613d: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17342 +/- ##
============================================
- Coverage 72.48% 72.38% -0.11%
Complexity 65637 65637
============================================
Files 5303 5304 +1
Lines 304793 304820 +27
Branches 44202 44206 +4
============================================
- Hits 220926 220631 -295
- Misses 65711 66087 +376
+ Partials 18156 18102 -54 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 22, 2025
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
55e613d to
cedf10d
Compare
Contributor
jainankitk
approved these changes
Feb 24, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
* [rule based autotagging] add attribute value store Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * make the store interface generic Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * run spotless apply Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add missing javadoc Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * improve javadoc for attribute value store Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * improve binary search bisecting expression Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add licenses directory Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> (cherry picked from commit 4648c3f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwperks
added a commit
that referenced
this pull request
Feb 27, 2025
* [rule based autotagging] add attribute value store * add CHANGELOG entry * make the store interface generic * run spotless apply * add missing javadoc * improve javadoc for attribute value store * improve binary search bisecting expression * add licenses directory --------- (cherry picked from commit 4648c3f) Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Craig Perkins <cwperx@amazon.com>
This was referenced Jan 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change will allow us to store prefix based string values in-memory structures. This will be fundamental to process Rules or any prefix based structure in memory.
Changes in this PR
Related Issues
#16797 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.