Fix interchanged formats of total_indexing_buffer_in_bytes and total_indexing_buffer#17070
Merged
reta merged 2 commits intoopensearch-project:mainfrom Jan 21, 2025
Merged
Conversation
…swapped in nodes API Signed-off-by: hye-on <ain0103@naver.com>
…search-project#17070 Signed-off-by: hye-on <ain0103@naver.com>
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17070 +/- ##
============================================
+ Coverage 72.06% 72.25% +0.18%
- Complexity 65214 65334 +120
============================================
Files 5301 5301
Lines 303823 303823
Branches 44033 44033
============================================
+ Hits 218955 219516 +561
+ Misses 66896 66300 -596
- Partials 17972 18007 +35 ☔ View full report in Codecov by Sentry. |
Contributor
|
Thanks @hye-on , I agree with you that this is difficult to address in a backward compatible way, targeting 3.0.0 would make perfect sense. |
reta
approved these changes
Jan 21, 2025
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
…indexing_buffer (opensearch-project#17070) * Fix total_indexing_buffer_in_bytes and total_indexing_buffer formats swapped in nodes API Signed-off-by: hye-on <ain0103@naver.com> * Move changelog entry to CHANGELOG-3.0 and update PR reference to opensearch-project#17070 Signed-off-by: hye-on <ain0103@naver.com> --------- Signed-off-by: hye-on <ain0103@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix format interchange between
total_indexing_buffer_in_bytesandtotal_indexing_bufferfields in nodes API response.total_indexing_buffer_in_bytesshould display raw bytes (e.g. 53687091)total_indexing_buffershould display human readable format (e.g. 51.1mb)Related Issues
Resolves #16910
Comments
I considered this change to be a breaking change and implemented it to take effect starting from version 3.0.0.
Would it be appropriate to apply this change to the 2.x versions as well?
If so, I would consider implementing it as follows:
Thank you for your time and consideration!
Check List
(Based on the feedback I previously received, it was mentioned that for breaking changes, the companion PR should be created after the current PR is merged. I will make sure to create the PR after this change is merged. Thank you!)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.