Support JDK-23 (build time and runtime) by reta · Pull Request #16257 · opensearch-project/OpenSearch

reta · 2024-10-09T17:44:52Z

Description

Support JDK-23 (build time and runtime)

Related Issues

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

libs/grok/src/main/java/org/opensearch/grok/GrokCaptureConfig.java

github-actions · 2024-10-09T18:48:20Z

❌ Gradle check result for 1e6c67a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-10-09T20:07:01Z

❌ Gradle check result for 1e6c67a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-10-09T21:01:44Z

❌ Gradle check result for 1e6c67a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

peternied · 2024-10-09T21:05:48Z

@reta Looks like you are iterating, LMK when you'd like a deeper look - fundamentally I approve!

github-actions · 2024-10-10T18:36:35Z

❌ Gradle check result for 2d1efcb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta · 2024-10-10T20:43:56Z

@peternied all set! thank you!

reta · 2024-10-10T20:53:19Z

The check is green but GA script is stuck:

parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 1, column 10
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
parse error: Invalid numeric literal at line 4, column 14
Workflow running status :Attempt 1/10 failed. The jq processing failed with exit code: 4. Retrying...
Attempt 2/10 failed. The jq processing failed with exit code: 4. Retrying...
Attempt 3/10 failed. The jq processing failed with exit code: 4. Retrying...
Attempt 4/10 failed. The jq processing failed with exit code: 4. Retrying...
Attempt 5/10 failed. The jq processing failed with exit code: 4. Retrying...
Attempt 6/10 failed. The jq processing failed with exit code: 4. Retrying...
true
Complete the run, checking results now......
Use queue information to find build number in Jenkins if available
parse error: Invalid numeric literal at line 5, column 12
WORKFLOW_URL

https://build.ci.opensearch.org/job/gradle-check/49237/

github-actions · 2024-10-10T21:45:48Z

❌ Gradle check result for e5ac86f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-10-10T23:28:43Z

❕ Gradle check result for e5ac86f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2024-10-10T23:29:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.03%. Comparing base (691f725) to head (e5ac86f).
Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #16257      +/-   ##
============================================
- Coverage     72.06%   72.03%   -0.04%     
+ Complexity    64822    64804      -18     
============================================
  Files          5308     5308              
  Lines        302574   302565       -9     
  Branches      43710    43710              
============================================
- Hits         218048   217945     -103     
- Misses        66648    66735      +87     
- Partials      17878    17885       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 1e7f6df) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Support JDK-23 (build time and runtime) (#16257) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 1e7f6df) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update DistroTestPlugin.java Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Update version.properties Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io>

peternied · 2024-10-11T15:20:44Z

Thanks for reviewing this @msfroh

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

yuye-aws · 2024-11-21T06:15:56Z

buildSrc/version.properties

+mockito           = 5.14.1
 objenesis         = 3.2
-bytebuddy         = 1.14.9
+bytebuddy         = 1.15.4


@reta Can we backport this version update change to 2.x?

Let me provide some context here. I'm working on the skills repo. I've created a PR to fix the CI error by bumping the version of bytebuddy, but it is very strange that its backport-2.x PR meets with the version conflict error:

* What went wrong: Execution failed for task ':compileTestJava'. > Could not resolve all dependencies for configuration ':testCompileClasspath'. > Conflict found for the following module: - net.bytebuddy:byte-buddy between versions 1.15.10 and 1.15.4

Do you have any hint on why? I do not have much context on these dependencies.

The 2.x is on 15.10 as well (#16657), I will take a look shortly why the CI for the skills repo repo fails.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

peterzhuamazon · 2025-02-27T23:26:07Z

Hi @reta maybe now we need to switch this to JDK21 since we are releasing 3.0.0 from main?

Thanks.

reta · 2025-02-27T23:28:03Z

Hi @reta maybe now we need to switch this to JDK21 since we are releasing 3.0.0 from main?\n\nThanks.

I think our goal is JDK-24 :)))), thanks @peterzhuamazon

andrross · 2025-03-04T19:00:25Z

Hi @reta maybe now we need to switch this to JDK21 since we are releasing 3.0.0 from main?\n\nThanks.

I think our goal is JDK-24 :)))), thanks @peterzhuamazon

@reta I'm thinking now that we plan to do the 3.x releases from the main branch, we should keep the bundled JDK to the latest LTS version. We can still build with the latest JDK, but only bundle the newest LTS. So that means we should probably change the bundled JDK on main to 21 for now, and update to JDK 24 when it is released. What do you think?

reta · 2025-03-05T01:32:08Z

So that means we should probably change the bundled JDK on main to 21 for now, and update to JDK 24 when it is released. What do you think?

Thanks @andrross , I think it makes sense, moreover next LTS is just 6 months away, so we could keep 21 for now and test on JDK-23/24 and target JDK-25

peterzhuamazon · 2025-03-05T01:50:00Z

Hi @reta @andrross :

Thanks!

reta commented Oct 9, 2024

View reviewed changes

libs/grok/src/main/java/org/opensearch/grok/GrokCaptureConfig.java Show resolved Hide resolved

reta added backport 2.x Backport to 2.x branch skip-changelog labels Oct 9, 2024

This was referenced Oct 10, 2024

[AUTOCUT] Gradle Check Flaky Test Report for ApproximatePointRangeQueryTests #15807

Open

[AUTOCUT] Gradle Check Flaky Test Report for ResourceAwareTasksTests #14293

Closed

Support JDK-23 (build time and runtime)

e5ac86f

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta force-pushed the issue-16255 branch from 2d1efcb to e5ac86f Compare October 10, 2024 18:59

msfroh approved these changes Oct 10, 2024

View reviewed changes

reta merged commit 1e7f6df into opensearch-project:main Oct 10, 2024

opensearch-trigger-bot bot mentioned this pull request Oct 10, 2024

[Backport 2.x] Support JDK-23 (build time and runtime) #16277

Merged

opensearch-ci-bot mentioned this pull request Oct 11, 2024

[AUTOCUT] Gradle Check Flaky Test Report for RemoteStoreIT #16145

Open

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024

Support JDK-23 (build time and runtime) (opensearch-project#16257)

bf7e1b3

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024

Support JDK-23 (build time and runtime) (opensearch-project#16257)

683e43f

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024

Support JDK-23 (build time and runtime) (opensearch-project#16257)

1e8ad3b

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

yuye-aws reviewed Nov 21, 2024

View reviewed changes

akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Jan 21, 2025

Support JDK-23 (build time and runtime) (opensearch-project#16257)

ac26ea9

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

peterzhuamazon mentioned this pull request Feb 27, 2025

[RELEASE] Release version 3.0.0 opensearch-project/opensearch-build#3747

Closed

66 tasks

peterzhuamazon mentioned this pull request Mar 5, 2025

Switch main/3.x to use JDK21 LTS version #17515

Merged

opensearch-ci-bot mentioned this pull request Apr 1, 2025

[AUTOCUT] Gradle Check Flaky Test Report for GoogleCloudStorageBlobContainerRetriesTests #17744

Open

Conversation

reta commented Oct 9, 2024

Description

Related Issues

Check List

Uh oh!

Uh oh!

github-actions bot commented Oct 9, 2024

Uh oh!

github-actions bot commented Oct 9, 2024

Uh oh!

github-actions bot commented Oct 9, 2024

Uh oh!

peternied commented Oct 9, 2024

Uh oh!

github-actions bot commented Oct 10, 2024

Uh oh!

reta commented Oct 10, 2024

Uh oh!

reta commented Oct 10, 2024

Uh oh!

github-actions bot commented Oct 10, 2024

Uh oh!

github-actions bot commented Oct 10, 2024

Uh oh!

codecov bot commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

peternied commented Oct 11, 2024

Uh oh!

yuye-aws Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

yuye-aws Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

reta Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

peterzhuamazon commented Feb 27, 2025

Uh oh!

reta commented Feb 27, 2025

Uh oh!

andrross commented Mar 4, 2025

Uh oh!

reta commented Mar 5, 2025

Uh oh!

peterzhuamazon commented Mar 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Oct 10, 2024 •

edited

Loading