Add support for restoring from snapshot with search replicas#16111
Merged
mch2 merged 12 commits intoopensearch-project:mainfrom Oct 23, 2024
Merged
Add support for restoring from snapshot with search replicas#16111mch2 merged 12 commits intoopensearch-project:mainfrom
mch2 merged 12 commits intoopensearch-project:mainfrom
Conversation
Contributor
|
❌ Gradle check result for 7556720: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
mch2
reviewed
Oct 1, 2024
server/src/main/java/org/opensearch/snapshots/RestoreService.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/cluster/routing/SearchOnlyReplicaRestoreTests.java
Outdated
Show resolved
Hide resolved
.../src/internalClusterTest/java/org/opensearch/indices/replication/SearchReplicaRestoreIT.java
Outdated
Show resolved
Hide resolved
.../src/internalClusterTest/java/org/opensearch/indices/replication/SearchReplicaRestoreIT.java
Outdated
Show resolved
Hide resolved
.../src/internalClusterTest/java/org/opensearch/indices/replication/SearchReplicaRestoreIT.java
Outdated
Show resolved
Hide resolved
.../src/internalClusterTest/java/org/opensearch/indices/replication/SearchReplicaRestoreIT.java
Outdated
Show resolved
Hide resolved
.../src/internalClusterTest/java/org/opensearch/indices/replication/SearchReplicaRestoreIT.java
Outdated
Show resolved
Hide resolved
.../src/internalClusterTest/java/org/opensearch/indices/replication/SearchReplicaRestoreIT.java
Outdated
Show resolved
Hide resolved
Contributor
|
❌ Gradle check result for 7f03249: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Oct 2, 2024
Contributor
mch2
approved these changes
Oct 23, 2024
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16111-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9dd1a59847ad8c2716d002716521ac40afc69355
# Push it to GitHub
git push --set-upstream origin backport/backport-16111-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
vinaykpud
added a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Oct 24, 2024
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <pudyodu@amazon.com>
vinaykpud
added a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Oct 24, 2024
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
vinaykpud
added a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Oct 25, 2024
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <pudyodu@amazon.com>
vinaykpud
added a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Oct 25, 2024
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
vinaykpud
added a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Oct 25, 2024
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
vinaykpud
added a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Oct 25, 2024
vinaykpud
added a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Oct 25, 2024
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
vinaykpud
added a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Oct 25, 2024
…rch-project#16111) Signed-off-by: Vinaya Krishna Pudyodu <vinkrish.neo@gmail.com>
vinaykpud
added a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Oct 25, 2024
…rch-project#16111) Signed-off-by: Vinaya Krishna Pudyodu <vinkrish.neo@gmail.com>
vinaykpud
added a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Oct 25, 2024
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
mch2
pushed a commit
that referenced
this pull request
Oct 31, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
…rch-project#16111) * Add support for restoring from snapshot with search replicas Signed-off-by: Vinay Krishna Pudyodu <pudyodu@amazon.com> * Fixed PR comments Signed-off-by: Vinay Krishna Pudyodu <pudyodu@amazon.com> * Fixed the issues in gradle precommit Signed-off-by: Vinay Krishna Pudyodu <pudyodu@amazon.com> * Fixed flaky tests Signed-off-by: Vinay Krishna Pudyodu <pudyodu@amazon.com> * Fixed precommit failure Signed-off-by: Vinay Krishna Pudyodu <pudyodu@amazon.com> * Fixed the codecoverage for RestoreService Signed-off-by: Vinay Krishna Pudyodu <pudyodu@amazon.com> * Fixed precommit failure Signed-off-by: Vinay Krishna Pudyodu <pudyodu@amazon.com> * removing unwanted tests Signed-off-by: Vinay Krishna Pudyodu <pudyodu@amazon.com> * Update CHANGELOG.md Co-authored-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> --------- Signed-off-by: Vinay Krishna Pudyodu <pudyodu@amazon.com> Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> Co-authored-by: Vinay Krishna Pudyodu <pudyodu@amazon.com> Co-authored-by: Marc Handalian <handalm@amazon.com>
This was referenced Apr 14, 2025
This was referenced Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR we are adding,
DOCUMENTandSEGMENTreplication type while snapshot restoration. Following are the allowed rules:DOCUMENTcan be restored toDOCUMENTorSEGMENTtypes. If we are restoring toSEGMENTtype more search replicas can be added.SEGMENTand without any search replicas can be restored toDOCUMENTorSEGMENTtypes. If we are restoring toSEGMENTtype more search replicas can be added.SEGMENTand with search replicas can be restored toDOCUMENTorSEGMENTtypes. If we are restoring toSEGMENTtype more search replicas can be added. If we are restoring toDOCUMENTtype search replica count must be set to 0 in the settings.Related Issues
Resolves #15532
Related #15306
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.