Fix Flaky Test SpecificClusterManagerNodesIT.testElectOnlyBetweenClusterManagerNodes#16021
Conversation
|
❕ Gradle check result for 1b3920b: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
Checking the history of this test, has this been flaky for more than a year? The only code related to cluster manager election that I've been able to find changed more recently than ~5 years ago (besides renaming) is the introduction of DecommisionService in 2023. |
test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java
Outdated
Show resolved
Hide resolved
|
❕ Gradle check result for 40548ec: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
@rajiv-kv, would you please help merge the pull request at your convenience. |
test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java
Outdated
Show resolved
Hide resolved
|
Minor comment, thanks for picking it up @kkewwei |
test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java
Outdated
Show resolved
Hide resolved
…terManagerNodes Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>
|
❕ Gradle check result for 366bb52: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
org.opensearch.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureEnforcedEnabledDisabledSetting #14331 |
|
@shwetathareja @andrross please have a look when you are free. |
…terManagerNodes (#16021) (#17265) (cherry picked from commit 852011a) Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…terManagerNodes (#16021) (#18320) (cherry picked from commit 852011a) Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
The case is as follows:
When the
node_t1is excluded from the vote config, and the cluster starts a new leader election, but the the nodenode_t2hasn't been elected as the new leader.At the moment, we send request to get the ClusterManager, we first get ClusterManager name, and leads to the NullPointerException.
internalCluster().nonClusterManagerClient()-> ......->getClusterManagerName()OpenSearch/test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java
Line 2171 in f0ea056
Related Issues
Resolves #15944 #16015
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.